-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor keycloak cli command code #2968
base: main
Are you sure you want to change the base?
Conversation
based on playwright video, it looks like the env was not ready by the time the kernel started, since there is no wait condition there it ended up failling during the assert with blank vs expected value. I will rerun this |
I took the liberty to include a ❯ nebari keycloak list-groups -c nebari-config.yaml
name | permissions
-----------------------------------------------------------------------------------
admin | jupyterhub_admin, dask_gateway_admin, allow-group-directory-
| creation-role, grafana_admin, argo-admin, conda_store_admin
analyst | jupyterhub_developer, allow-group-directory-creation-role,
| allow-read-access-to-services-role, grafana_viewer, argo-viewer,
| conda_store_developer
custom | conda_store_analyst_admin
developer | jupyterhub_developer, allow-group-directory-creation-role,
| dask_gateway_developer, grafana_developer, argo-developer,
| conda_store_developer
superadmin | realm-admin, conda_store_superadmin
users |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks like it all works to me! Would be maybe nice to add a few unit tests.
Reference Issues or PRs
Refactors code in keycloak nebari cli. Adds the ability to add user to groups via the cli command as well.
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
After a deployment, run
nebari keycloak adduser --user my_user my_password --groups developer --groups admin --config nebari-config.yaml
and ensuremy_user
is created and is in the admin and developer groups (as well as the default groups).Any other comments?