Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suggestion that teams can be part of groups #124

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

swrobel
Copy link
Contributor

@swrobel swrobel commented Aug 14, 2024

It seems that this README suggestion was perhaps added in haste in #45 as I can't see any code that was added that would support looking "inside" a team to determine if the author is a member, and handle review requests appropriately based on that. See past reports that this is not working in #109

@swrobel swrobel changed the title Remove suggestion that teams can be listed as authors Remove suggestion that teams can be part of groups Aug 14, 2024
@solomonduncan
Copy link

+1 for this! Thank you! I couldn't figure out why it was not working as documented, so this has saved me a bit of debug headache.

@necojackarc
Copy link
Owner

Sorry, I've been working with a company GitHub account and kept missing notifications to my personal account... Thanks for the PR and good catch!

@necojackarc necojackarc merged commit 5864393 into necojackarc:master Sep 17, 2024
2 checks passed
@swrobel swrobel deleted the patch-1 branch September 17, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants