[email protected]

## [1.3.0-pre.4] - 2024-07-17 ### Changed * Updated Burst dependency to version 1.8.16 ### Deprecated * The `ENABLE_SIMPLE_SYSTEM_DEPENDENCIES` feature will be removed in a future package release, as it no longer provides significant benefit for expected DOTS workloads. * The `EntityQueryCaptureMode.AtRecord` enum value in `EntityCommandBuffer` is now deprecated. All users should migrate to `EntityQueryCaptureMode.AtPlayback`. Capture-at-record mode can be several hundred times slower than capture-at-playback. If capture-at-record semantics are required and performance isn't a concern, the array of entities matching the query can be captured manually and passed to the corresponding `EntityCommandBuffer` command. ### Fixed * Usage of SystemAPI.GetComponentRW and SystemAPI.GetComponentRO in Entities.ForEach. * Regression in compilation time with assemblies with lots of system methods. * EntityComponentStore leaked memory during domain reload.
needle-mirror · Jul 17, 2024 · 69124c8 · 69124c8
1 parent c2a2808
commit 69124c8
Show file tree

Hide file tree

Showing 43 changed files with 251 additions and 33 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,24 @@ uid: changelog
 
 # Changelog
 
+## [1.3.0-pre.4] - 2024-07-17
+
+### Changed
+
+* Updated Burst dependency to version 1.8.16
+
+### Deprecated
+
+* The `ENABLE_SIMPLE_SYSTEM_DEPENDENCIES` feature will be removed in a future package release, as it no longer provides significant benefit for expected DOTS workloads.
+* The `EntityQueryCaptureMode.AtRecord` enum value in `EntityCommandBuffer` is now deprecated. All users should migrate to `EntityQueryCaptureMode.AtPlayback`. Capture-at-record mode can be several hundred times slower than capture-at-playback. If capture-at-record semantics are required and performance isn't a concern, the array of entities matching the query can be captured manually and passed to the corresponding `EntityCommandBuffer` command.
+
+### Fixed
+
+* Usage of SystemAPI.GetComponentRW and SystemAPI.GetComponentRO in Entities.ForEach.
+* Regression in compilation time with assemblies with lots of system methods.
+* EntityComponentStore leaked memory during domain reload.
+
+
 ## [1.3.0-exp.1] - 2024-06-11
 
 ### Added

diff --git a/Documentation~/index.md b/Documentation~/index.md
@@ -10,6 +10,7 @@ See the [DOTS Guide and Samples](https://github.com/Unity-Technologies/EntityCom
 
 * 2022.3 (LTS)
 * 2023.3 (Latest Beta and beyond)
+* Unity 6
 
 ## Package installation
 

diff --git a/Unity.Entities.Build/DotsGlobalSettings.cs b/Unity.Entities.Build/DotsGlobalSettings.cs
@@ -71,6 +71,8 @@ public virtual int Importance
             get { return 0; }
         }
 
+        public virtual string ProviderPath { get; set; } = "Project/Entities/Build";
+
         /// <summary>
         /// Provides extra scripting defines to add into the player build.
         /// </summary>

diff --git a/Unity.Entities.Build/EntitiesBuildSettingsProvider.cs b/Unity.Entities.Build/EntitiesBuildSettingsProvider.cs
@@ -22,17 +22,20 @@ public override void OnActivate(string searchContext, VisualElement rootElement)
             rootElement.styleSheets.Add(stylesheet);
             rootElement.AddToClassList("sb-settings-window");
 
-            var title = new Label("Entities");
+            var title = new Label("Build");
             title.AddToClassList("title");
             rootElement.Add(title);
 
+            var subTitle = new Label("Entities");
+            subTitle.AddToClassList("subtitle");
+            rootElement.Add(subTitle);
+
             var element = new VisualElement();
             element.AddToClassList("body");
 
             // Activate providers
-            for (int i = 0; i < instance.Providers.Count; i++)
+            foreach (var extraSetting in instance.Providers)
             {
-                var extraSetting = instance.Providers[i];
                 extraSetting.OnActivate(instance.GetPlayerType(), element);
             }
             rootElement.Add(element);
@@ -43,7 +46,13 @@ public override void OnActivate(string searchContext, VisualElement rootElement)
         [SettingsProvider]
         public static SettingsProvider CreateDotsGlobalSettingsProvider()
         {
-            return new EntitiesBuildSettingsProvider("Project/Entities/Build", SettingsScope.Project);
+            var projectSettingsPath = "Project/Entities/Build";
+            var instance = DotsGlobalSettings.Instance;
+            if (instance.ServerProvider != null)
+            {
+                projectSettingsPath = instance.ServerProvider.ProviderPath;
+            }
+            return new EntitiesBuildSettingsProvider(projectSettingsPath, SettingsScope.Project);
         }
     }
 }

diff --git a/Unity.Entities.Build/StyleSheets/dots-settings-window.uss b/Unity.Entities.Build/StyleSheets/dots-settings-window.uss
@@ -13,14 +13,32 @@
     margin-left: 5px;
 }
 
+.subtitle{
+    -unity-font-style: bold;
+    font-size: 13px;
+    margin-bottom: 5px;
+    margin-left: 5px;
+}
+
 .body{
     margin-left: 5px;
 }
 
 .target {
-    margin-left: 10px;
     margin-top: 5px;
-    -unity-font-style: bold;
+    -unity-font-style: normal;
+}
+
+.target .unity-enum-field {
+    margin-left: 0;
+}
+
+.target .unity-enum-field__input {
+    margin-left: 110px;
+}
+
+.unity-property-field .unity-list-view__size-field {
+    min-width: 100px;
 }
 
 .target-Settings{

diff --git a/Unity.Entities.Tests/EntityCommandBufferDebugViewTests.cs b/Unity.Entities.Tests/EntityCommandBufferDebugViewTests.cs
@@ -823,7 +823,9 @@ public void EntityCommandBufferDebugView_AddComponentForEntityQuery_CaptureAtRec
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.AddComponent<EcsTestData2>(query, EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -862,7 +864,9 @@ public void EntityCommandBufferDebugView_AddComponentTypeForEntityQuery_CaptureA
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.AddComponent(query, ComponentType.ReadWrite<EcsTestData2>(), EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -944,7 +948,9 @@ public void EntityCommandBufferDebugView_AddComponentTypesForEntityQuery_Capture
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.AddComponent(query, componentTypes, EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -987,7 +993,9 @@ public void EntityCommandBufferDebugView_AddSharedComponentForEntityQuery_Captur
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.AddSharedComponent(query, new EcsTestSharedComp { value = 17 }, EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -1118,7 +1126,9 @@ public void EntityCommandBufferDebugView_SetSharedComponentForEntityQuery_Captur
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.SetSharedComponent(query, new EcsTestSharedComp { value = 17 }, EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -1160,7 +1170,9 @@ public void EntityCommandBufferDebugView_RemoveComponentTypeForEntityQuery_Captu
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.RemoveComponent(query, ComponentType.ReadWrite<EcsTestData>(), EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -1199,7 +1211,9 @@ public void EntityCommandBufferDebugView_RemoveComponentForEntityQuery_CaptureAt
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.RemoveComponent<EcsTestData>(query, EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -1241,7 +1255,9 @@ public void EntityCommandBufferDebugView_RemoveComponentTypesForEntityQuery_Capt
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.RemoveComponent(query, componentTypes, EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;
@@ -1284,7 +1300,9 @@ public void EntityCommandBufferDebugView_DestroyEntitiesForEntityQuery_ContainsE
 
             using var query = m_Manager.CreateEntityQuery(typeof(EcsTestData));
             using var ecb = new EntityCommandBuffer(World.UpdateAllocator.Handle);
+#pragma warning disable 0618 // EntityQueryCaptureMode.AtRecord is obsolete.
             ecb.DestroyEntity(query, EntityQueryCaptureMode.AtRecord);
+#pragma warning restore
             var ecbView = new EntityCommandBuffer.EntityCommandBufferDebugView(ecb);
 
             var commands = ecbView.Commands;