Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard server port command line argument #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

absolutely-vivid
Copy link

Hi, I added a command line argument to let the user choose port for the dashboard server. If a port isn't specified, it falls back to the original behavior of picking a random port.

@neevek
Copy link
Owner

neevek commented Aug 13, 2024

Hi vivid,

There are two things we need to take into account when adding this feature:

  1. If the newly added command line option accepts a sockaddr, the user can specify any ip address other than the one used to run the omnip server, which the dashboard server will fail to bind on. Maybe specifying a port is enough.
  2. The specified port may be in use, we need to handle the error in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants