Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] expand key hash actions #1107

Merged
merged 4 commits into from
Nov 12, 2024
Merged

[API] expand key hash actions #1107

merged 4 commits into from
Nov 12, 2024

Conversation

jbygdell
Copy link
Collaborator

Description
This PR ads the missing functions for managing the key hashses

How to test
Run the integration test

@jbygdell jbygdell requested a review from a team October 29, 2024 11:33
@jbygdell jbygdell self-assigned this Oct 29, 2024
@jbygdell jbygdell changed the title Feature/api keyhash actions [API] expand key hash actions Oct 29, 2024
@jbygdell jbygdell force-pushed the feature/api-keyhash-actions branch from f53cc74 to 5a57281 Compare November 4, 2024 09:40
Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have one comment and one question.

sda/cmd/api/api.go Show resolved Hide resolved
sda/cmd/api/api.go Outdated Show resolved Hide resolved
@jbygdell jbygdell force-pushed the feature/api-keyhash-actions branch from 0edfd5a to cf34114 Compare November 4, 2024 13:36
@jbygdell jbygdell force-pushed the feature/api-keyhash-actions branch from cf34114 to 38a1b7a Compare November 5, 2024 10:26
@jbygdell jbygdell enabled auto-merge November 5, 2024 14:33
Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jbygdell jbygdell added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit dabdadb Nov 12, 2024
27 checks passed
@jbygdell jbygdell deleted the feature/api-keyhash-actions branch November 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants