Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework integration-test setup #1150

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

jbygdell
Copy link
Collaborator

@jbygdell jbygdell commented Nov 27, 2024

Description
Given the ongoing work with the admin API and the fact that the sync service needs a full rework some changes to the tests are required.

  • Split out sync test to a separate docker compose file
  • Only run the sync test if the code in the cmd/sync* subfolders change
  • Expand the Makefile so that it will be easier to run the tests without having to rebuild the containers or run tests not related to the ongoing work (posix, s3, sync)

Notice
As part of this the release of version tagged artifacts, containers and charts are disabled, so we don't release anything that is not working properly.
This will be resolved when we move over to using release branches.

@jbygdell jbygdell marked this pull request as ready for review November 27, 2024 10:05
@jbygdell jbygdell marked this pull request as draft November 27, 2024 10:05
@jbygdell jbygdell changed the title Tests/rework integrationtest setup Rework integration-test setup Nov 27, 2024
@jbygdell jbygdell force-pushed the tests/rework-integrationtest-setup branch 5 times, most recently from 5576184 to 14428db Compare November 27, 2024 10:59
@jbygdell jbygdell force-pushed the tests/rework-integrationtest-setup branch from 14428db to 34b1004 Compare November 27, 2024 11:00
@jbygdell jbygdell self-assigned this Nov 27, 2024
@jbygdell jbygdell requested a review from a team November 27, 2024 11:08
@jbygdell jbygdell marked this pull request as ready for review November 27, 2024 11:08
pahatz
pahatz previously approved these changes Nov 27, 2024
Copy link
Contributor

@pahatz pahatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

MalinAhlberg
MalinAhlberg previously approved these changes Nov 28, 2024
Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! I just have one question.

Makefile Show resolved Hide resolved
@jbygdell jbygdell dismissed stale reviews from MalinAhlberg and pahatz via 88df8d0 November 28, 2024 14:28
Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbygdell jbygdell added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@jbygdell jbygdell added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 837b2c8 Nov 29, 2024
7 checks passed
@jbygdell jbygdell deleted the tests/rework-integrationtest-setup branch November 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants