Run services manually with go run #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanjiangshu
changed the title
nanjiangshu
force-pushed
the
feature/manual-go-run
branch
from
dccba42 to
0f4d694
Compare
jbygdell
requested changes
Dec 9, 2024
MalinAhlberg
previously approved these changes
Dec 10, 2024
nanjiangshu
force-pushed
the
feature/manual-go-run
branch
2 times, most recently
from
20d528f to
73f8a27
Compare
jbygdell
reviewed
Dec 10, 2024
jbygdell
requested changes
Dec 10, 2024
There was a problem hiding this comment.
The DEVELOPMENT.md file has a ver different layout compared to the other markdown files. It would be better if this file also followed the same layout i.e remove all the numbered list items for starter.
Secondly it would be much easier if you started using a markdown linter in order to catch all the other issues, mainly missing empty lines between sections and trailing white spaces.
nanjiangshu
force-pushed
the
feature/manual-go-run
branch
2 times, most recently
from
2cefebe to
ac447f1
Compare
jbygdell
reviewed
Dec 11, 2024
Co-authored-by: Joakim Bygdell <[email protected]>
nanjiangshu
force-pushed
the
feature/manual-go-run
branch
from
73d8d3f to
de39a95
Compare
jbygdell
approved these changes
Dec 11, 2024
aaperis
reviewed
Dec 12, 2024
MalinAhlberg
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #1155
Description
Additional notes
The bug for the integration test of sda-download has been there for quite some time.
How to test
Follow the instructions in DEVELOPMENT.md and verify that everything functions as expected.