Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide endpoint with info for sda-cli login #208

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Provide endpoint with info for sda-cli login #208

merged 3 commits into from
Dec 19, 2023

Conversation

pahatz
Copy link
Contributor

@pahatz pahatz commented Jun 28, 2023 •
edited
Loading

Provides the endpoint /info with the parameters needed by sda-cli to login

closes #200

@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch from aa2df17 to a07df6a Compare June 29, 2023 08:09
pahatz
pahatz commented Jun 29, 2023
View reviewed changes
sda-auth/info.go Outdated Show resolved Hide resolved
@pahatz pahatz self-assigned this Jun 29, 2023
@pahatz pahatz requested a review from a team June 29, 2023 08:16
jbygdell
jbygdell requested changes Jun 29, 2023
View reviewed changes
sda-auth/main.go Show resolved Hide resolved
sda-auth/info.go Outdated Show resolved Hide resolved
sda-auth/info.go Outdated Show resolved Hide resolved
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch 2 times, most recently from a67ed0d to e0c1174 Compare July 10, 2023 20:28
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch from e0c1174 to ddbacf9 Compare July 12, 2023 13:58
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch from ddbacf9 to bc4a09a Compare August 7, 2023 13:01
@kusalananda
Copy link
Contributor

This says it closes 200, but 200 is already closed.

@pahatz
Copy link
Contributor Author

pahatz commented Aug 21, 2023

Yes, I wasn't aware of the issue that github creates itself, the PR will be here: #208

pontus
pontus reviewed Aug 21, 2023
View reviewed changes
sda-auth/info.go Outdated Show resolved Hide resolved
pontus
pontus reviewed Aug 21, 2023
View reviewed changes
sda-auth/info.go Outdated Show resolved Hide resolved
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch 4 times, most recently from 5b37610 to 5a92938 Compare August 22, 2023 11:05
@pahatz pahatz marked this pull request as ready for review August 22, 2023 11:05
jbygdell
jbygdell requested changes Aug 23, 2023
View reviewed changes
sda-auth/dev-server/docker-compose.yml Outdated Show resolved Hide resolved
sda-auth/config.yaml Outdated Show resolved Hide resolved
sda-auth/info.go Show resolved Hide resolved
sda-auth/info.go Outdated Show resolved Hide resolved
sda-auth/keys/c4gh_key.pub.pem Outdated Show resolved Hide resolved
sda-auth/keys/c4gh_key.sec.pem Outdated Show resolved Hide resolved
@jbygdell
Copy link
Collaborator

git rebase origin/main

@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch from 5a92938 to a941cbb Compare August 23, 2023 08:07
@jbygdell jbygdell changed the title #200: Provide endpoint with info for sda-cli login Provide endpoint with info for sda-cli login Aug 23, 2023
pontus
pontus reviewed Aug 23, 2023
View reviewed changes
sda-auth/info.go Outdated Show resolved Hide resolved
pontus
pontus reviewed Aug 23, 2023
View reviewed changes
sda-auth/info.go Outdated Show resolved Hide resolved
pontus
pontus reviewed Aug 23, 2023
View reviewed changes
sda-auth/info.go Outdated Show resolved Hide resolved
aaperis
aaperis requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@aaperis aaperis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the README file :-)

sda-auth/config_test.go Outdated Show resolved Hide resolved
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch 2 times, most recently from d94b32d to 3d5c370 Compare August 25, 2023 13:00
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch from 3d5c370 to c641035 Compare August 31, 2023 07:07
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch 13 times, most recently from f00c0d2 to 537704c Compare December 14, 2023 01:38
jbygdell
jbygdell requested changes Dec 14, 2023
View reviewed changes
.github/integration/scripts/charts/dependencies.sh Outdated Show resolved Hide resolved
charts/sda-svc/templates/auth-deploy.yaml Outdated Show resolved Hide resolved
charts/sda-svc/templates/auth-deploy.yaml Outdated Show resolved Hide resolved
sda-auth/dev-server/docker-compose.yml Outdated Show resolved Hide resolved
sda-auth/main.go Outdated Show resolved Hide resolved
sda-auth/main.go Outdated Show resolved Hide resolved
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch 4 times, most recently from 35cc0d4 to 37b833f Compare December 14, 2023 15:55
jbygdell
jbygdell requested changes Dec 15, 2023
View reviewed changes
charts/sda-svc/templates/auth-deploy.yaml Show resolved Hide resolved
charts/sda-svc/templates/auth-deploy.yaml Outdated Show resolved Hide resolved
@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch 3 times, most recently from 4a9eb5f to 6dc05a6 Compare December 15, 2023 13:03
aaperis
aaperis approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pahatz pahatz force-pushed the 200-provide-info-for-cli-login branch from 6dc05a6 to 56a8453 Compare December 19, 2023 10:37
@pahatz pahatz merged commit 333e14b into main Dec 19, 2023
27 checks passed
@pahatz pahatz deleted the 200-provide-info-for-cli-login branch December 19, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostas-kou kostas-kou kostas-kou left review comments

@pontus pontus pontus left review comments

@aaperis aaperis aaperis approved these changes

@jbygdell jbygdell jbygdell approved these changes

Assignees

@pahatz pahatz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sda-auth] Provide endpoint for sda-cli login
7 participants
@pahatz @kusalananda @jbygdell @codecov-commenter @pontus @kostas-kou @aaperis