Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sda-auth] update to go1.20 #276

Merged
merged 4 commits into from
Sep 5, 2023
Merged

[sda-auth] update to go1.20 #276

merged 4 commits into from
Sep 5, 2023

Conversation

aaperis
Copy link
Contributor

@aaperis aaperis commented Aug 31, 2023

Update to go1.20 and update modules from #264, #265 while avoiding the toolchain bug in dependabot.

Also add a small fix in the compose file to make life easier.

@aaperis aaperis requested a review from a team August 31, 2023 06:08
@pontus
Copy link
Contributor

pontus commented Aug 31, 2023

Do we want to do this? I did some research and the toolchain addition is a bug that should be fixed now (dependabot is having issues with parts of the sensitive-data-archive for other reasons and thus asking it to recreate the PR doesn't currently work).

I have a slight preference for not doing this as bumping to 1.21 involves work on most platforms.

@kusalananda
Copy link
Contributor

kusalananda commented Aug 31, 2023

Do we want to do this? I did some research and the toolchain addition is a bug that should be fixed now (dependabot is having issues with parts of the sensitive-data-archive for other reasons and thus asking it to recreate the PR doesn't currently work).

I have a slight preference for not doing this as bumping to 1.21 involves work on most platforms.

What about doing the other updates that dependabot suggests, but leaving the toolchain update (and Go version bump) for later?

@kusalananda
Copy link
Contributor

In the morning meeting, we discussed moving to 1.20 (which I presume means 1.20.7, the latest 1.20 release), and applying the dependabot changes not related to the toolchain. I believe @aaperis said he'll do something along these lines later.

@aaperis aaperis force-pushed the auth-update-to-go1.21 branch from c3eecd7 to b5c32be Compare August 31, 2023 11:26
@kusalananda
Copy link
Contributor

But see failing test: https://github.com/neicnordic/sensitive-data-archive/actions/runs/6036698927/job/16379492436?pr=276

@aaperis aaperis force-pushed the auth-update-to-go1.21 branch from b5c32be to aa2eaa8 Compare August 31, 2023 11:52
@aaperis aaperis force-pushed the auth-update-to-go1.21 branch from aa2eaa8 to 1eb38a3 Compare August 31, 2023 12:11
@aaperis aaperis changed the title [sda-auth] update to go1.21 [sda-auth] update to go1.20 Aug 31, 2023
@aaperis aaperis force-pushed the auth-update-to-go1.21 branch from 67dcde1 to 3bd4321 Compare August 31, 2023 18:30
@jbygdell
Copy link
Collaborator

jbygdell commented Sep 1, 2023

But see failing test: https://github.com/neicnordic/sensitive-data-archive/actions/runs/6036698927/job/16379492436?pr=276

That test seems to fail randomly, it will be removed with the merging of the sda-pipeline folder.

@dbampalikis dbampalikis merged commit b2ec8b5 into main Sep 5, 2023
30 checks passed
@dbampalikis dbampalikis deleted the auth-update-to-go1.21 branch September 5, 2023 13:31
@aaperis aaperis mentioned this pull request Sep 22, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants