Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEGA usecase] Merge internal components from sda-pipeline into sda #302

Merged
merged 16 commits into from
Sep 25, 2023
Merged

[FEGA usecase] Merge internal components from sda-pipeline into sda #302

merged 16 commits into from
Sep 25, 2023

Conversation

jbygdell
Copy link
Collaborator

  • Merges all internal components into sda
  • Updates s3inbox to work with the inernal components
  • Removes unused stuff from broker.

@jbygdell jbygdell requested a review from a team September 15, 2023 13:11
@jbygdell jbygdell self-assigned this Sep 15, 2023
@jbygdell jbygdell force-pushed the merge_sda_pipeline_1 branch from 595fcc0 to da60067 Compare September 15, 2023 13:41
@jbygdell jbygdell removed the request for review from a team September 15, 2023 13:41
@jbygdell jbygdell changed the title Merge sda pipeline 1 Merge internal from sda-pipeline Sep 15, 2023
@jbygdell jbygdell changed the title Merge internal from sda-pipeline Merge internal components from sda-pipeline Sep 15, 2023
@jbygdell jbygdell force-pushed the merge_sda_pipeline_1 branch from da60067 to 4c5e3c1 Compare September 15, 2023 14:02
@jbygdell jbygdell requested a review from a team September 15, 2023 14:13
@jbygdell jbygdell marked this pull request as ready for review September 15, 2023 14:13
@jbygdell jbygdell force-pushed the merge_sda_pipeline_1 branch from 4c5e3c1 to 6efb28c Compare September 15, 2023 14:14
@jbygdell jbygdell changed the title Merge internal components from sda-pipeline Merge internal components from sda-pipeline into sda Sep 15, 2023
@jbygdell jbygdell changed the title Merge internal components from sda-pipeline into sda [FEGA usecase] Merge internal components from sda-pipeline into sda Sep 17, 2023
@jbygdell jbygdell force-pushed the merge_sda_pipeline_1 branch 2 times, most recently from 0619bf2 to 2b87991 Compare September 18, 2023 16:43
@jbygdell
Merge broker from sda-pipeline
c614b4f
@jbygdell
Merge storage from sda-pipeline
ff91d90
@jbygdell
Rework storage_test to run as a suite.
c64785d 
Also removes all mocked backends in favor for live containers.
@jbygdell
Merge config from sda-pipeline
4b19104
@jbygdell
Merge in database from sda-pipeline
eb4a539
@jbygdell
Update s3inbox to use the merged config & proxy code
6f3b53c
@jbygdell
Merge bucket from s3inbox into internal/storage
4d65339
@jbygdell
Deduplicate code
2d6ab57 
`newS3Backend` and `CheckS3Bucket` had some overlap that where put as a separate function.
@jbygdell
[integration tests] Change timings of sda healthchecks
22a84fe
@jbygdell
Remove unused variable from SendMessage
1699900
@jbygdell
Rename main to s3inbox
9afa2e0
@jbygdell
Remove routingkey option for error messages
8d44f21 
They will be sent to `error`
@jbygdell
GO mod update
13a2f3d
@jbygdell
[s3inbox] fix helthcheck url
6cc385b
@jbygdell
[charts][sda-svc] fix s3inbox ENVs
2d56356
@jbygdell jbygdell force-pushed the merge_sda_pipeline_1 branch from 2b87991 to 2d56356 Compare September 22, 2023 12:37
@jbygdell
Move formatUploadFilePath from helper.go to proxy.go
89bf3db 
Now the `helper.go` is exclusively used by the tests
blankdots
blankdots reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing

sda/internal/config/config.go Show resolved Hide resolved
@jbygdell jbygdell merged commit 5556545 into main Sep 25, 2023
28 checks passed
@jbygdell jbygdell deleted the merge_sda_pipeline_1 branch September 25, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaperis aaperis aaperis approved these changes

@blankdots blankdots blankdots approved these changes

@pontus pontus pontus approved these changes

Assignees

@jbygdell jbygdell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbygdell @pontus @blankdots @aaperis