Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional checks to fix panics observed in production #317

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Add additional checks to fix panics observed in production #317

merged 2 commits into from
Sep 25, 2023

Conversation

pontus
Copy link
Contributor

@pontus pontus commented Sep 20, 2023

Add a few checks for bad cases observed in production.

jbygdell
jbygdell previously approved these changes Sep 20, 2023
View reviewed changes
sda/cmd/s3inbox/userauth.go Outdated Show resolved Hide resolved
@pontus @jbygdell
Remove empty line
15ada7c 
Co-authored-by: Joakim Bygdell <[email protected]>
nanjiangshu
nanjiangshu approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@nanjiangshu nanjiangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I'm a bit curious what are the panics observed in production. Maybe in a Slack thread?

@pontus pontus merged commit dffb160 into main Sep 25, 2023
28 checks passed
@pontus pontus deleted the fix_crash_bad_call_s3proxy branch September 25, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbygdell jbygdell jbygdell approved these changes

@nanjiangshu nanjiangshu nanjiangshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pontus @nanjiangshu @jbygdell