Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/htsget seekable #831

Merged
merged 9 commits into from
Apr 29, 2024
Merged

Feat/htsget seekable #831

merged 9 commits into from
Apr 29, 2024

Conversation

MalinAhlberg
Copy link
Contributor

@MalinAhlberg MalinAhlberg commented Apr 23, 2024

Related issue(s) and PR(s)
This PR closes #696 and neicnordic/sda-download#372.
It includes the changes of #820, but is based on #826 instead of #703.

Description

  • Remove the second header for re-encryption (server-public-key)
  • Remove the user-agent check for the requester
  • The content-length is now including the header size when htsget requests the encrypted file size
  • The range header returns an extra character, according to specification
  • Includes the PR Seekable S3 support, second take #826 code, to make random access possible

How to test

Also see #701 and #776.

@MalinAhlberg MalinAhlberg force-pushed the feat/htsget_seekable branch from 8e90329 to 092cf1c Compare April 25, 2024 07:09
@aaperis
Copy link
Contributor

aaperis commented Apr 26, 2024

We should merge this PR which also covers #820

@MalinAhlberg MalinAhlberg marked this pull request as ready for review April 26, 2024 11:13
@MalinAhlberg MalinAhlberg requested a review from a team April 26, 2024 11:13
@MalinAhlberg MalinAhlberg added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 42c97fb Apr 29, 2024
26 checks passed
@MalinAhlberg MalinAhlberg deleted the feat/htsget_seekable branch April 29, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sda-download] Implement random access in encrypted files
5 participants