Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] server public key as a base64 encoded string #947

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

jbygdell
Copy link
Collaborator

Related issue(s) and PR(s)
This PR closes #886.

Description
Serve the public key from the info endpoint as a base64 encoded string instead of a hex string.

How to test

curl -sL HOSTNAME/info | jq -r '.public_key | @base64d' > pubkey.pem

The file should look like this:

-----BEGIN CRYPT4GH PUBLIC KEY-----
ji8ko8dTv4r+TR7h58TKzcqMfBkXf68mLDL9MZ/FBlk=
-----END CRYPT4GH PUBLIC KEY-----

@jbygdell jbygdell added go Pull requests that update Go code Summer task labels Jul 18, 2024
@jbygdell jbygdell requested a review from a team July 18, 2024 07:19
@jbygdell jbygdell self-assigned this Jul 18, 2024
@jbygdell jbygdell force-pushed the feature/issue_886 branch 2 times, most recently from 6cadf94 to 4c668b8 Compare July 22, 2024 09:13
@jbygdell jbygdell force-pushed the feature/issue_886 branch from 4c668b8 to f91d9b5 Compare July 23, 2024 08:21
jbygdell added 2 commits July 23, 2024 10:37
By serving the public key as a base64 encoded string a user can actually use it by calling the info endpoint like this: `curl -sL HOSTNAME/info | jq -r '.public_key | @base64d' > pubkey.pem`
@jbygdell jbygdell force-pushed the feature/issue_886 branch from f91d9b5 to 0d760ea Compare July 23, 2024 08:37
@jbygdell jbygdell requested a review from a team July 23, 2024 08:41
@jbygdell jbygdell added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit f491483 Jul 25, 2024
24 checks passed
@jbygdell jbygdell deleted the feature/issue_886 branch July 25, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code Summer task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Auth] serve the full public key as base64 encoded string in the info endpoint
3 participants