-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First stab at creating admin endpoints in the API #955
Conversation
216e141
to
926abb6
Compare
926abb6
to
59bf42a
Compare
Returns the correlation ID for a `submision_filepath` - `user` combination as long as the file is not part of a dataset.
59bf42a
to
5b9b7e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Also very nice tests added 👌 .
I left some minor comments, I'm ready to approve when the comments in api_test.go
have been fixed.
Failure to look up the Correlation ID can be 400 or 500 depending on where the error originated from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good :-)
Background
For standalone setups, like the one used in GDI, there are a need to be able to take care of the administrative tasks without the need to have direct access to the MQ or the PostgreSQL database.
This PR begins the process of simplifying these administrative tasks.
The first goal is to be able to handle the ingestion process i.e. trigger the ingestion of a file, assign a stable ID to the file and in the end create a dataset from a set of stable IDs.
Description
First take on the admin API
How to test