M9: Build performance test report view #9
Conversation
ninetteadhikari
force-pushed
the
feat/billboardjs
branch
from
7202b6a to
66a8213
Compare
ninetteadhikari
changed the title
ninetteadhikari
force-pushed
the
feat/billboardjs
branch
from
66a8213 to
4491f4f
Compare
Update chart: add date as x-axis, ux improvements
| dataY.unshift('value'); | ||
|
|
||
| let axisFormat | ||
| // Date is saved as string in the data |
There was a problem hiding this comment.
Comments are important, but I think some of them can be removed. :)
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Example: https://naver.github.io/billboard.js/demo/#Chart.SimpleXYLineChart |
There was a problem hiding this comment.
removed as I added apache echarts
There was a problem hiding this comment.
This is not a fix :) And can be part of the first commit
There was a problem hiding this comment.
yea sorry about this 🙈 I need to update all the commit messages to remove 'fix' and combine some of them
There was a problem hiding this comment.
also not a fix 🐫
Could you merge the style changes into the first commit and have this one only for descriptions?
There was a problem hiding this comment.
What happened here? same commit twice?
There was a problem hiding this comment.
hmm must have happened when I rebased it.. will clean up ☝️
scripts/oe-build-perf-report
Outdated
There was a problem hiding this comment.
this is the commit history of the performance test shown in the charts. I increased the default from 25 to 300. This was one of the requirements in the Sow.
This PR does the following:
start_timestart_timeas date for x-axis charts