Hide private args; convert "_"->"-" in *args name. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
force-pushed
the
underscore-in-arg-name
branch
3 times, most recently
from
12a5033 to
7ddac0a
Compare
anntzer
force-pushed
the
underscore-in-arg-name
branch
from
7ddac0a to
96b2e83
Compare
| @@ -181,7 +181,7 @@ def func(*file_paths): | |||
| argh.set_default_command(parser, func) | |||
|
|
|||
| assert parser.add_argument.mock_calls == [ | |||
| mock.call('file_paths', nargs='*', | |||
| mock.call('file_paths', nargs='*', metavar='file-paths', | |||
There was a problem hiding this comment.
What happens in the case without the metavar arg?
There was a problem hiding this comment.
It's always called with a metavar now, see line 120 of the patch to assembling.py.
|
Closing for lack of activity and because I don't use argh anymore; feel free to pick up the patch if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes both paths of #79.