Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type annotation of errors in wrap_errors #229

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix type annotation of errors in wrap_errors #229

merged 2 commits into from
Jul 9, 2024

Conversation

laazy
Copy link
Contributor

@laazy laazy commented Jul 9, 2024

original typing is List[Exception], which is not the type of Exception class such as [AssertionError].
should be fixed as List[Type[Exception]].

@laazy
Fix type annotation of errors in wrap_errors
9ef9a62 
original typing is List[Exception], which is not the type of Exception class such as [AssertionError]. should be fixed as List[Type[Exception]].
@neithere neithere added the bug label Jul 9, 2024
@neithere neithere added this to the 0.31.3 milestone Jul 9, 2024
neithere
neithere approved these changes Jul 9, 2024
View reviewed changes
Copy link
Owner

@neithere neithere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good catch!

Could you please change I've just changed the target branch from master to release/v0.31.3 (#225).

@neithere neithere changed the base branch from master to release/v0.31.3 July 9, 2024 12:03
@neithere neithere merged commit 66c4472 into neithere:release/v0.31.3 Jul 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neithere neithere neithere approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.31.3
Development

Successfully merging this pull request may close these issues.
2 participants
@laazy @neithere