Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Studio menu/button to display Unit's Tags (feature flagged) (#3… #24

Merged
merged 1 commit into from
May 15, 2024

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented May 7, 2024

Description

This is a backport of openedx#33563 and basically in the palm version shows the following

image

After pressing the button

image

For more details follow the instructions of the original PR

@andrey-canon andrey-canon requested a review from johanseto May 8, 2024 15:43
@andrey-canon andrey-canon force-pushed the and/backport_taxonomy_tab branch from 38f3af6 to 447c4b6 Compare May 8, 2024 22:03
Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some considerations:

  • I have followed the instructions to import taxonomies.
    The command failed to the type of import courses(zip),so I cherry-pick this commit but I don't know if could be useful.
    feat: Add support for zip files to course and library import code openedx/edx-platform#34191
  • I added the django-flag to taxonomies list and doesn't works me for a good time until I create only one unit. After that, the other units show me everything tag button.
  • Statics: I don't know If i need a special command to run the static in studio. I ran them, but the taxonomy widget loads me in the footer and strange.
    2024-05-08_18-13
  • Anyway the taxonomy route in course-authoring seems working in the desired behaviour.
    Peek 2024-05-08 18-24

2024-05-08_18-26

@andrey-canon
Copy link
Collaborator Author

Some considerations:

  • I have followed the instructions to import taxonomies.
    The command failed to the type of import courses(zip),so I cherry-pick this commit but I don't know if could be useful.
    feat: Add support for zip files to course and library import code openedx/edx-platform#34191

  • I added the django-flag to taxonomies list and doesn't works me for a good time until I create only one unit. After that, the other units show me everything tag button.

  • Statics: I don't know If i need a special command to run the static in studio. I ran them, but the taxonomy widget loads me in the footer and strange.
    2024-05-08_18-13

  • Anyway the taxonomy route in course-authoring seems working in the desired behaviour.
    Peek 2024-05-08 18-24

        [
          
        
            ![Peek 2024-05-08 18-24](https://private-user-images.githubusercontent.com/51926076/329081968-b8800e3f-f3e5-4e2a-b73d-48ef1603c071.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTUyMTM3NTksIm5iZiI6MTcxNTIxMzQ1OSwicGF0aCI6Ii81MTkyNjA3Ni8zMjkwODE5NjgtYjg4MDBlM2YtZjNlNS00ZTJhLWI3M2QtNDhlZjE2MDNjMDcxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA5VDAwMTA1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNkNmQ5ZGI3ZDIyYjU0YzEyY2EyMzcyMjI4MGI5M2FlMDFhMmRkYTZlN2U4OGJhNWJjZWIyYmRjYmY3NzU3MmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zL9P6UEv_gpz91SrA7OyQIgwdjVbFuFzHEfmlo9t40Y)
          ](https://private-user-images.githubusercontent.com/51926076/329081968-b8800e3f-f3e5-4e2a-b73d-48ef1603c071.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTUyMTM3NTksIm5iZiI6MTcxNTIxMzQ1OSwicGF0aCI6Ii81MTkyNjA3Ni8zMjkwODE5NjgtYjg4MDBlM2YtZjNlNS00ZTJhLWI3M2QtNDhlZjE2MDNjMDcxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA5VDAwMTA1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNkNmQ5ZGI3ZDIyYjU0YzEyY2EyMzcyMjI4MGI5M2FlMDFhMmRkYTZlN2U4OGJhNWJjZWIyYmRjYmY3NzU3MmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zL9P6UEv_gpz91SrA7OyQIgwdjVbFuFzHEfmlo9t40Y)
        
        
          
            
              
            
            
              
              
            
          
          [
            
              
            
          ](https://private-user-images.githubusercontent.com/51926076/329081968-b8800e3f-f3e5-4e2a-b73d-48ef1603c071.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTUyMTM3NTksIm5iZiI6MTcxNTIxMzQ1OSwicGF0aCI6Ii81MTkyNjA3Ni8zMjkwODE5NjgtYjg4MDBlM2YtZjNlNS00ZTJhLWI3M2QtNDhlZjE2MDNjMDcxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA5VDAwMTA1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNkNmQ5ZGI3ZDIyYjU0YzEyY2EyMzcyMjI4MGI5M2FlMDFhMmRkYTZlN2U4OGJhNWJjZWIyYmRjYmY3NzU3MmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zL9P6UEv_gpz91SrA7OyQIgwdjVbFuFzHEfmlo9t40Y)
    

2024-05-08_18-26

  1. I didn't generate the data because the same taxonomy page has the option to export and import tags, so I can not help you with that
  2. I don't understand the issue you had, could you explain the steps to replicate that ?
  3. I just used basic commando like openedx-assets webpack --env=prod and openedx-assets themes --theme-dirs /openedx/themes/nelp-edx-themes --themes nelp-edx-theme

@andrey-canon andrey-canon force-pushed the and/backport_taxonomy_tab branch 2 times, most recently from 3898b92 to ac06e18 Compare May 9, 2024 23:35
@johanseto johanseto self-requested a review May 10, 2024 21:46
Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used the webpack command with --env=prod and works.
=)
Peek 2024-05-10 16-45

I only think this PR need a rebase .

Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used the webpack command with --env=prod and works.
=)
Peek 2024-05-10 16-45

I only think this PR need a rebase .

@andrey-canon andrey-canon force-pushed the and/backport_taxonomy_tab branch from ac06e18 to bcce1d7 Compare May 14, 2024 19:24
@andrey-canon andrey-canon changed the base branch from and/backport_taxonomy_tab to open-release/palm.nelp May 15, 2024 17:01
@andrey-canon andrey-canon merged commit d29967a into open-release/palm.nelp May 15, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants