Skip to content

Commit

Permalink
feat!: upgraded to node v18, added .nvmrc and updated workflows (open…
Browse files Browse the repository at this point in the history
…edx#452)

BREAKING CHANGE: upgrade node JS to support to v18

* feat: upgraded to node v18, added .nvmrc and updated workflows

* refactor: updated packages
  • Loading branch information
BilalQamar95 authored Mar 28, 2023
1 parent 5380b1f commit 42da734
Show file tree
Hide file tree
Showing 6 changed files with 1,023 additions and 16,633 deletions.
14 changes: 4 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,17 @@ on:
jobs:
tests:
runs-on: ubuntu-20.04
strategy:
matrix:
node: [16]
npm: [8.5.x]
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV

- name: Setup Nodejs
uses: actions/setup-node@v3
with:
node-version: "${{ matrix.node }}"

# This is a temporary "hack" to unblock CI/releases, as ideally we should avoid needing to pin NPM to a specific minor version. By doing
# so, we are basically deferring clean up of peer dependencies to a later time. See https://github.com/npm/cli/issues/4664 for more details.
- name: Pin NPM version
run: npm install -g npm@${{ matrix.npm }}
node-version: ${{ env.NODE_VER }}

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lockfileversion-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ on:

jobs:
version-check:
uses: openedx/.github/.github/workflows/lockfileversion-check.yml@master
uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master
5 changes: 4 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ jobs:
with:
fetch-depth: 0

- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 18
node-version: ${{ env.NODE_VER }}

- name: Install dependencies
run: npm ci
Expand Down
3 changes: 1 addition & 2 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
v16

18
Loading

0 comments on commit 42da734

Please sign in to comment.