And/migrate set custom colors #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
force-pushed
the
and/migrate_set_custom_colors
branch
from
5336c16 to
858a4a6
Compare
johanseto
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
I tested in my local and works as desired.
having priority the PARAGON_THEME_URLS over the CUSTOM_PRIMARY_COLORS
Screencast from 17-01-24 14:46:10.webm
| const primary = CUSTOM_PRIMARY_COLORS['pgn-color-primary-base']; | ||
|
|
||
| if (!primary) { | ||
| if (!primary || PARAGON_THEME_URLS != null) { |
There was a problem hiding this comment.
This make me thing... whatever you define with the var PARAGON_THEME_URLS in the mfe_config would discard the CUSTOM_PRIMARY_COLORS feature. But for the moment seems functional.
If the PARAGON_THEME_URLS has been set the primary colors wont' be set on runtime
andrey-canon
force-pushed
the
and/migrate_set_custom_colors
branch
from
858a4a6 to
8a3c344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There are 3 commits
PARAGON_THEME_URL, in this case if the settingsPARAGON_THEME_URLhas been set the method will ignore the set_custom_colors logic otherwise this is going to work like it did before.How to test