Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redwood mig/set custom primary colors #5

Merged

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Nov 22, 2024

Description

Migration pr of #2 issue

How to test

  1. Clone frontend-platform repo into the src/mfe folder (repo frontend-platform=open-release/redwood.nelp from nelc repo)
  2. Go to the main folder a run npm install
  3. Add the module.config.js file into the frontend-app-learning folder
module.exports = {
    localModules: [
        { moduleName: '@edx/frontend-platform', dir: '../frontend-platform', dist: 'src' },
    ],
};
  1. Restart the learning mfe service, docker attach container and then ctrl+c
  2. checkout this branch
  3. Follow the instructions of the original PR

Results

brand-openedx = https://github.com/nelc/brand-openedx/tree/redwood-mig/add_nelp_typography

    "CUSTOM_PRIMARY_COLORS": {
        "pgn-color-primary-base": "#AA0000",
    },

image

@andrey-canon andrey-canon force-pushed the redwood-mig/set_custom_primary_colors branch 2 times, most recently from 386dc10 to af730e6 Compare November 26, 2024 18:39
@andrey-canon andrey-canon changed the base branch from open-release/redwood.nelp to and/fix_redwood_tests November 26, 2024 18:39
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in my local env

Screencast.from.26-11-24.16.34.24.webm

@andrey-canon andrey-canon force-pushed the redwood-mig/set_custom_primary_colors branch from af730e6 to 914af41 Compare November 28, 2024 18:31
@andrey-canon andrey-canon changed the base branch from and/fix_redwood_tests to open-release/redwood.nelp November 28, 2024 18:31
@andrey-canon andrey-canon merged commit f94b99c into open-release/redwood.nelp Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants