And/backport parser to know path #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
I test with a npm run build in a learning mfe using a frontend-platform with this change.
This change is being carried in the compiles files. No way to test it better, we need to move it into a dist mfe published version.
By the moment the static files keep the code and there is no problem with the built.
Screencast from 17-01-24 15:27:39.webm
This add function to get path from a string url from utils. Also the function is implemented to the history module. In order to match with URLS as webpack allow.(CDN). Test were developed for different shaped of string urls with path. A basic test is also added for the base case in the history variable for the initialize with base case of PUBLIC_PATH=`/`.
andrey-canon
force-pushed
the
and/backport_parser_to_know_path
branch
from
12684e8 to
2501c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a backport of openedx#568 however I'm not sure how to test it, @johanseto could you help me with that?