Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add openedx folder to ignore patters, remove unnecessary imports... #6

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: add openedx folder to ignore patters, remove unnecessary imports... #6

merged 2 commits into from
Nov 28, 2024

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Nov 26, 2024 •
edited
Loading

Description:

This includes two commits issue

  1. This reverts commit be1dd62. That basically doesn't fix anything
  2. This really fixes the tests

johanseto
johanseto approved these changes Nov 26, 2024
View reviewed changes
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Easier change in package.json, anyway the package-lock.json was updated a lot but nothing to do (Y)

@andrey-canon andrey-canon merged commit 0d474ee into open-release/redwood.nelp Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanseto johanseto johanseto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrey-canon @johanseto