Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Git Hooks for Linting #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ArchTaqi
Copy link

What does it do?

  • Added .npmrc and .nvmrc file to lock the node engine
  • Added Husky to run the Git hooks before committing and pushing.
    • .husky/pre-commit is added to run the yarn lint before any commit is added
    • .husky/pre-push runs yarn build to make code can successfully build before push to git.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • Make sure the app compiles in both dev and prod mode by running yarn dev and yarn build
  • New and existing unit, integration, and e2e tests pass locally with my changes
  • My changes generate no new warnings (browser console and Node.js terminal)
  • There are no new linting yarn lint and typing yarn types errors
  • Make sure the code is formatted by running yarn format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant