Ensure tests fail on stderr and pipe errors #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the munit process exits with a success code, even if there is an error creating the buffer for
stderr
or an error creating the pipe to the forked process. This PR ensures thatreport.errored
is incremented on both those errors, ensuring the process exits with an error code.Note that the appropriate
report
counter is currently incremented everywhere else the test result is updated:munit/munit.c
Lines 1205 to 1226 in fbbdf14
munit/munit.c
Lines 1385 to 1386 in fbbdf14
munit/munit.c
Lines 1431 to 1432 in fbbdf14