Updated to Neo 3.6.0

[cschuchardt88]

Porting to Neo 3.6.0

brought up to coding standards well.

Ported and updated neo-blockchaintoolkit-library to this repo. Since development has stopped for https://github.com/N3developertoolkit/neo-blockchaintoolkit-library and developer left.

Changed all configurations since repo is outdated and some projects are dead.

[cschuchardt88]

@dotnet-policy-service agree

[cschuchardt88]

Only thing is I don't know if your Github actions will build it right, I'll have a look at that.

Someone let me know, what you want to do going follow with this project. How we can setup github actions.

This is working build (action won't work, need new actions)...

[cschuchardt88]

@gsmachado @steven1227 does anyone monitor this repo anymore? I would like to knock this out and some issues.

[steven1227]

@gsmachado @steven1227 does anyone monitor this repo anymore? I would like to knock this out and some issues.

Yes. We are looking into it as well.

[ixje]

I think it's hard to follow what actually changed when also reformatting almost every file. Those should really be separate PRs. Also, why are there Plugin binaries checked in?

[cschuchardt88]

Look at

neo-express/src/neoxp/neoxp.csproj

Lines 15 to 28 in e75c812

	<Choose>
	<When Condition=" '$(BlockchainToolkitLibraryVersion)' == 'local'">
	<ItemGroup>
	<ProjectReference Include="$(NeoMonorepoPath)\modules\src\DBFTPlugin\DBFTPlugin.csproj" />
	<ProjectReference Include="$(NeoMonorepoPath)\modules\src\RpcServer\RpcServer.csproj" />
	</ItemGroup>
	</When>
	<Otherwise>
	<ItemGroup>
	<PackageReference Include="Neo.Consensus.DBFT" Version="$(NeoVersion)" />
	<PackageReference Include="Neo.Plugins.RpcServer" Version="$(NeoVersion)" />
	</ItemGroup>
	</Otherwise>
	</Choose>

The configurations make assumptions that you have these files, along with other things, Like directories outside this repo's directory.

Like:

neo-express/src/Directory.Build.props

Lines 21 to 27 in e75c812

	<PropertyGroup>
	<BlockchainToolkitLibraryVersion>3.6.13-preview</BlockchainToolkitLibraryVersion>
	<!-- <BlockchainToolkitLibraryVersion>local</BlockchainToolkitLibraryVersion> -->
	<BlockchainToolkitLibraryLocalPath>..\..\..\lib-bctk</BlockchainToolkitLibraryLocalPath>
	<NeoVersion>3.5.0</NeoVersion>
	<NeoMonorepoPath>..\..\..\..\official\3neo-monorepo</NeoMonorepoPath>
	</PropertyGroup>

<add key="neo-monorepo" value="https://neomonorepopackages.blob.core.windows.net/packages/index.json" />

Here are the thinks i changed.

• Naming conventions
• Moved neo-blockchaintoolkit-library to this repo (no more developer and dead repo)
  • Fixed code and updated Neo version 3.6.0
• Removed unnecessary or broken configurations
• Added .editorconfig
• Updated nuget.config
• Update Github actions to dotnet 7
• Removed unused or unnecessary packages from projects.

It's time to stop messing around and get this repo going again. I have tons of time on my hands. I tried many times to get in touch with core. I had someone on inside say developer left and it's not maintained anymore and this would be a place to start. So I'm just getting this repo up for public access... so anyone can start working on it. Should of been that way in the 1st place. That is one of the reasons why this repo was always dead. No support!

why are there Plugin binaries checked in?

oops

[Ashuaidehao]

Good work! We are planning reactive https://github.com/N3developertoolkit/neo-blockchaintoolkit-library, so moving bctk repo into neo-express is not most urgent task right now. Maybe we can continue this process after neo-express v3.6 release. If you have any improvement sugguestions, welcome issues and PRs in our repos.

[cschuchardt88]

There was some interface changes in neo-blockchaintoolkit-library on that respo. So i went ahead and implemented the missing methods on this repo for neo-blockchaintoolkit-library. Also i changed the naming conventions of the methods to meet dotnet code standards (thats why i added .editorconfig). If you would like i can put in a PR to get neo-blockchaintoolkit-library repo working with neo-express repo. Plus i use Visual Studio, not Visual Studio Code.

[ixje]

I had someone on inside say developer left and it's not maintained anymore and this would be a place to start. So I'm just getting this repo up for public access... so anyone can start working on it. Should of been that way in the 1st place. That is one of the reasons why this repo was always dead.

I think it's public knowledge by now that the author left the NEO community for a different adventure. We're waiting for @JohndeVadoss to come with the new plan who's going to maintain it. There's more than enough things to fix and improve in this project, but without an active accountable person we're just stuck.

[steven1227]

I had someone on inside say developer left and it's not maintained anymore and this would be a place to start. So I'm just getting this repo up for public access... so anyone can start working on it. Should of been that way in the 1st place. That is one of the reasons why this repo was always dead.

I think it's public knowledge by now that the author left the NEO community for a different adventure. We're waiting for @JohndeVadoss to come with the new plan who's going to maintain it. There's more than enough things to fix and improve in this project, but without an active accountable person we're just stuck.

I discussed with NGDseattle and there will be a person working on it in near future. For now, our highest priority is to update and release it to compatible with 3.6

[cschuchardt88]

For now, our highest priority is to update and release it to compatible with 3.6

Waiting on N3developertoolkit/neo-blockchaintoolkit-library#91 to merge

[cschuchardt88]

@steven1227 neo-express relies on neo-blockchaintoolkit-library. I had to update that too. Thats why i added neo-blockchaintoolkit-library to this repo instead. You can use this PR if you like to get it going until someone merges at that repo. Or at least test it out.

Also updated N3developertoolkit/neo3-visual-tracker#166 But if you end up merging neo-express I would need to update neo3-visual-tracker PR to reflect the new version. But will work with old version too. Cause nothing changed in the api as far as i can tell.

But all is good now. Just waiting for a tigger to be pulled. The way i look at is if no one is maintaining these repos. Then this is the best solution so far. Instead of learning old inefficient code and coding standards. Lets resurrect the update with best coding practices.

It was really annoying for me when i 1st came to neo, to try to learn. You shouldn't have to read the source code of the application to get something to work. With that said I been there and done that. Let's get going..... 😠

[Jim8y]

my� bad for changing the status, cont control myself to click it when there is a button.