Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change account output from scripthash to address #459

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

chenzhitong
Copy link
Member

close #296

@chenzhitong chenzhitong changed the title update Change account output from scripthash to address Jul 31, 2024
@chenzhitong
Copy link
Member Author

I can successfully compile locally, but Github Action doesn't work

@cschuchardt88
Copy link
Member

I can successfully compile locally, but Github Action doesn't work

Add import for Neo.Extensions library for 'ToHexString' it was just moved to that library.

@chenzhitong
Copy link
Member Author

I can successfully compile locally, but Github Action doesn't work

Add import for Neo.Extensions library for 'ToHexString' it was just moved to that library.

I don't get it, I didn't add/modify the code for ToHexString

@cschuchardt88
Copy link
Member

I can successfully compile locally, but Github Action doesn't work

Add import for Neo.Extensions library for 'ToHexString' it was just moved to that library.

I don't get it, I didn't add/modify the code for ToHexString

Workflow updates the submodule to latest. Your machine isn't updated to latest for neo core

@chenzhitong
Copy link
Member Author

Some of the console output, although named “ScriptHash” in the code, is actually the address

@chenzhitong
Copy link
Member Author

Is there anything else that needs to be changed, I checked and there is no other method that outputs what should be address but actually outputs scripthash

@cschuchardt88
Copy link
Member

I think that's all

@cschuchardt88 cschuchardt88 merged commit 2a87023 into neo-project:master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make 'Address' the default representation for UInt160 types
2 participants