Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[
Fix
]: integer overflow inJumpTable.SubStr
#3496base: HF_Echidna
Are you sure you want to change the base?
[
Fix
]: integer overflow inJumpTable.SubStr
#3496Changes from 8 commits
98e834b
4a3c207
2494812
20ec1e1
7860aa8
f9fc6fc
5e8de32
40e5c1f
4772329
5f159d8
7864e0a
20daa54
2bf5125
da9db73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also add some tests for INT64, like:
It'll fail (in NeoGo it's
at instruction 22 (SUBSTR): not an int32
), but just to make sure.