Fix NEO callstates #3599

shargon · 2024-11-26T11:31:38Z

Description

Fixes #3596

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Manual

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

roman-khimov

vote method requires this too.

src/Neo/SmartContract/Native/NativeContract.cs

roman-khimov

Much better this way. Probably solving any other similar problems (like CpuFee updates). I'd try avoiding unnecessary changes, but that's nitpicking mostly.

src/Neo/ProtocolSettings.cs

src/Neo/SmartContract/Native/ContractMethodMetadata.cs

cschuchardt88

Please fix these memory leaks

src/Neo/ProtocolSettings.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

cschuchardt88 · 2024-11-26T23:04:05Z

src/Neo/ProtocolSettings.cs

@@ -131,7 +131,7 @@ public record ProtocolSettings
        /// <returns>The loaded <see cref="ProtocolSettings"/>.</returns>
        public static ProtocolSettings Load(Stream stream)
        {
-            var config = new ConfigurationBuilder().AddJsonStream(stream).Build();
+            using var config = new ConfigurationBuilder().AddJsonStream(stream).Build();


ConfigurationBuilder on build uses ConfigurationRoot may have to cast to it. either way needs to be fixed for memory leak.

or could do
((IDisposable)config).Dispose(); at of the method

https://github.com/dotnet/runtime/blob/9d5a6a9aa463d6d10b0b0ba6d5982cc82f363dc3/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationBuilder.cs#L53C24-L53C41

It was not a memory leak...

ConfiguationRoot is the class that is created for inherits from IConfigurationRoot

How isn't it a memory leak, The memory for the providers are still allocated? Streams and all.
https://github.com/dotnet/runtime/blob/9d5a6a9aa463d6d10b0b0ba6d5982cc82f363dc3/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationRoot.cs#L99C9-L112C10

Just do (config as IDisposable)?.Dispose() what's the big deal?

Fixed problem

src/Neo/SmartContract/Native/CryptoLib.cs

shargon · 2024-11-27T08:02:34Z

Ready to review again

src/Neo/ProtocolSettings.cs

src/Neo/SmartContract/Native/NeoToken.cs

AnnaShaleva

LGTM.

AnnaShaleva · 2024-12-04T19:28:41Z

src/Neo/SmartContract/Native/NativeContract.cs

-                ContractMethodAttribute attribute = member.GetCustomAttribute<ContractMethodAttribute>();
-                if (attribute is null) continue;
-                listMethods.Add(new ContractMethodMetadata(member, attribute));
+                foreach (var attribute in member.GetCustomAttributes<ContractMethodAttribute>())


Previously there was a check for if (attribute is null), is it possible that attribute is nil with the current implementation? I think it's OK, but we'd better make sure.

No, now can't be null

Allow callstates to use HF

4a1f660

shargon requested review from Jim8y and roman-khimov November 26, 2024 11:31

shargon added 2 commits November 26, 2024 12:33

Rename to method

6f31b4e

Other rename

a60bdac

shargon marked this pull request as ready for review November 26, 2024 11:37

shargon added the Waiting for Review label Nov 26, 2024

roman-khimov reviewed Nov 26, 2024

View reviewed changes

src/Neo/SmartContract/Native/NativeContract.cs Outdated Show resolved Hide resolved

shargon added 5 commits November 26, 2024 14:51

Change the way

6fa19aa

Reduce changes

66804dd

Reduce changes

4bced57

Adapt name always

2d760c1

Avoid string when only is lower the first char

4eb75bc

shargon requested a review from roman-khimov November 26, 2024 13:57

shargon added 2 commits November 26, 2024 16:12

UT

a989f9c

Test all

f860146

shargon added Bug Used to tag confirmed bugs Hardfork labels Nov 26, 2024

shargon changed the title ~~Allow callstates to use HF~~ Allow NEO callstates Nov 26, 2024

shargon changed the title ~~Allow NEO callstates~~ Fix NEO callstates Nov 26, 2024

roman-khimov reviewed Nov 26, 2024

View reviewed changes

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

src/Neo/SmartContract/Native/ContractMethodMetadata.cs Outdated Show resolved Hide resolved

cschuchardt88 previously requested changes Nov 26, 2024

View reviewed changes

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

src/Neo/ProtocolSettings.cs Show resolved Hide resolved

shargon and others added 2 commits November 26, 2024 23:46

Update src/Neo/ProtocolSettings.cs

68f3fdd

Co-authored-by: Christopher Schuchardt <[email protected]>

Update src/Neo/ProtocolSettings.cs

9bebffe

Co-authored-by: Christopher Schuchardt <[email protected]>

cschuchardt88 reviewed Nov 26, 2024

View reviewed changes

Jim8y reviewed Nov 27, 2024

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Show resolved Hide resolved

Jim8y added this to the v3.8.0 milestone Nov 27, 2024

Jim8y mentioned this pull request Nov 27, 2024

Add hardfork HF_Echidna #3454

Draft

9 tasks

Reuse Load from stream

2dd5e29

shargon added 4 commits November 27, 2024 08:55

Unify

6c7c89a

Fix default logic

c6db216

Change ContractMethod to allowMultiple

dad7e0d

Use LowerInvariant

ca9ddad

Move CheckingHardfork

753b66b

cschuchardt88 reviewed Nov 27, 2024

View reviewed changes

src/Neo/ProtocolSettings.cs Outdated Show resolved Hide resolved

roman-khimov approved these changes Nov 29, 2024

View reviewed changes

src/Neo/SmartContract/Native/NeoToken.cs Show resolved Hide resolved

shargon added 3 commits December 1, 2024 14:21

Remove optional arg

21444f0

Fix build

01ef226

Avoid file not found error

9432a2a

AnnaShaleva reviewed Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix NEO callstates #3599

Fix NEO callstates #3599

shargon commented Nov 26, 2024 •

edited

Loading

roman-khimov left a comment

roman-khimov left a comment

cschuchardt88 left a comment

cschuchardt88 Nov 26, 2024 •

edited

Loading

shargon Nov 27, 2024

cschuchardt88 Nov 27, 2024 •

edited

Loading

shargon commented Nov 27, 2024

AnnaShaleva left a comment

AnnaShaleva Dec 4, 2024

shargon Dec 4, 2024

Fix NEO callstates #3599

Are you sure you want to change the base?

Fix NEO callstates #3599

Conversation

shargon commented Nov 26, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

roman-khimov left a comment

Choose a reason for hiding this comment

roman-khimov left a comment

Choose a reason for hiding this comment

cschuchardt88 left a comment

Choose a reason for hiding this comment

cschuchardt88 Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

shargon Nov 27, 2024

Choose a reason for hiding this comment

cschuchardt88 Nov 27, 2024 • edited Loading

Choose a reason for hiding this comment

shargon commented Nov 27, 2024

AnnaShaleva left a comment

Choose a reason for hiding this comment

AnnaShaleva Dec 4, 2024

Choose a reason for hiding this comment

shargon Dec 4, 2024

Choose a reason for hiding this comment

shargon commented Nov 26, 2024 •

edited

Loading

cschuchardt88 Nov 26, 2024 •

edited

Loading

cschuchardt88 Nov 27, 2024 •

edited

Loading