-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LevelDBStore
#3607
Open
cschuchardt88
wants to merge
7
commits into
neo-project:master
Choose a base branch
from
cschuchardt88:fix/leveldb-snapshot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve LevelDBStore
#3607
cschuchardt88
wants to merge
7
commits into
neo-project:master
from
cschuchardt88:fix/leveldb-snapshot
+79
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jim8y
previously approved these changes
Dec 3, 2024
shargon
reviewed
Dec 3, 2024
LGTM |
Jim8y
approved these changes
Dec 4, 2024
nan01ab
approved these changes
Dec 4, 2024
AnnaShaleva
approved these changes
Dec 4, 2024
shargon
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any benefit of allow to iterate without a snapshot, but if it's ok for all except me, I'm not against to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
GetEnumerator
toDB
,Store
andSnapshot
UIntPtr
/IntPtr
tonuint
/nint
GetSnapshot
toCreateSnapshot
NewIterator
toCreateIterator
DB
unit testsType of change
How Has This Been Tested?
TestLevelDb
TestLevelDbDatabase
TestLevelDbMultiSnapshot
TestLevelDbSnapshot
Test Configuration:
Checklist: