Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the example #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdrienneCohea
Copy link

I am trying graph databases for the first time and ran this example. It compiled and inserted nodes into my neo4j container, but it did not print when Mark was found. I believe this will provide a fix for new users of this crate so they can understand what to expect.

Below are the fixes I identified:

  • Query for mark instead of Mark, because neo4j is case-sensitive.
  • Spawn query tasks until mark is found, rather than spawning 42 async tasks which may all exit before the nodes are inserted into the graph.
  • Join on all tasks so that we always insert nodes into the graph and always query for mark before exiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant