Updated images #1210
Updated images #1210
Conversation
There was a problem hiding this comment.
Thanks @lidiazuin.
The images look good, except for:
- graph_clause_where.svg (the replacement replaces the old image)
- patterns-equijoins-solution_2.svg (I think the different solutions are less clear in this new format).
Also, how are you batching these updates? I see, e.g., that this PR replaces some but not all of the svgs in the Patterns chapter? Are those not replaced here not ready yet?
| @@ -678,7 +678,7 @@ RETURN type(r) AS type, m.title AS movie | |||
|
|
|||
| The result shows that he has 13 outgoing relationships connected to 12 different `Movie` nodes (12 have the `ACTED_IN` type and one has the `DIRECTED` type). | |||
|
|
|||
| image::introduction_example1.svg[width="500",role="middle"] | |||
| image::introduction-example1.svg[A Tom Hanks nodes connecting to Movie nodes via acted in relationships,width=600,role=popup] | |||
There was a problem hiding this comment.
| image::introduction-example1.svg[A Tom Hanks nodes connecting to Movie nodes via acted in relationships,width=600,role=popup] | |
| image::introduction-example1.svg[A Tom Hank Person node connected to Movie nodes via acted in relationships,width=600,role=popup] |
Co-authored-by: Jens Pryce-Åklundh <112686610+JPryce-Aklundh@users.noreply.github.com>
I don't understand your point here?
Isn't it the same image, only the nodes are organized differently? Maybe you can talk to Petar and explain to him what improvements could be made.
I'm adding all the images that Petar finished and sent to me in the first batch. I don't know in what order he's working with the images, but I would guess it's not after chapters since we have some missing, like the ones you pointed out. |
|
|
Would you like to revert the change in these two images and merge to publish the new ones or wait? |
|
where_clause.svg should be reverted, but I actually think it might be better to wait adding the images in the Patterns section until they are all done (i.e. all "patterns... .svg" files). |
|
This PR includes documentation updates Updated pages: |
…of images that are not being used but were updated
|
This PR includes documentation updates Updated pages: |
| @@ -2,6 +2,12 @@ | |||
| [[syntax-and-semantics]] | |||
| = Syntax and semantics | |||
|
|
|||
| //Check Mark | |||
There was a problem hiding this comment.
What does this do? (Preview isnt working)
There was a problem hiding this comment.
It replaces the current emoji ✅ for the checkmark we use in docs, so it should look like this instead:
No description provided.