Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure node expansion runs against the correct database #1975

Merged

Conversation

OskarDamkjaer
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer commented Aug 1, 2024

Using the database field on the result ensures that the right database is used for node expansion, even if the query dynamically switched database, for example like this:

:use neo4j
USE movies MATCH (n) RETURN n;

Copy link
Contributor

@nnecla nnecla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@daveajrussell daveajrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've repro-d on my neo4j desktop instance

Tested out the same steps on this and it's looking good

@OskarDamkjaer OskarDamkjaer merged commit 2190686 into neo4j:master Aug 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants