Adding advertisement tile for the new browser ui #1978
Conversation
src/browser/index.tsx
Outdated
| ;(async () => { | ||
| const doesPreferQuery = localStorage.getItem('prefersOldBrowser') === 'false' | ||
|
|
||
| const response = await fetch('/preview/manifest.json') |
There was a problem hiding this comment.
I think fetch can throw, so I think it'd be good with try { } catch { } here
There was a problem hiding this comment.
This also needs to be fetch('./preview/manifest.json') to handle the bundled case where it's under /browser/preview. And also to handle if users have set up their own custom hosting!
There was a problem hiding this comment.
Perfect point, changed it accordingly!
src/browser/index.tsx
Outdated
| const response = await fetch('/preview/manifest.json') | ||
| if (response.status === 200) { | ||
| if (doesPreferQuery) { | ||
| window.location.pathname = '/preview/' |
There was a problem hiding this comment.
In the bundled Browser case, the preview will be on http://localhost:7474/browser/preview and in the hosted case it's on browser.neo4j.io/preview.
So this would not work for bundled browser
There was a problem hiding this comment.
This is so true. I've also realised while testing that switching back to browser removes the whole path, instead of just removing the preview(i remember i've tested it but probably did not test it appropriately :/ ) But I can create another pr to fix the query side.
Changed this one to add preview to the current path.
| [experimentalFeaturePreviewName]: { | ||
| name: experimentalFeaturePreviewName, | ||
| on: false, | ||
| displayName: 'Advertise preview of new browser', | ||
| tooltip: 'Enable the advertisement tile of the new browser' | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this is a user facing feature flag, I think we're better off to just have it on always if isPreviewAvailable
nnecla
changed the title
Description
This pr is to add the
PreviewFramewhich contains the advertisement tile for the new browser UI. This frame will only be shown if the new UI is there, and the feature flag is on.Also, if user prefers the new UI, we switch to the new UI before the app renders.
The look of the frame is not final and wip.