Only load resources once for gametest servers #1632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code would load resources twice for gametest servers due to the positioning of the code, causing needless slowdown. This PR moves the gametest server creation to just after pack repository creation and before resources are loaded in
Main
. Neither the GUI nor the server shutdown thread are necessary for gametest servers.This PR also adds a test to make sure that reloadable regs support data maps (there were no code changes needed, this test is just to make sure it doesn't break in the future)
1.21.3 version of #1589