Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load resources once for gametest servers #1632

Merged

Conversation

Matyrobbrt
Copy link
Member

The current code would load resources twice for gametest servers due to the positioning of the code, causing needless slowdown. This PR moves the gametest server creation to just after pack repository creation and before resources are loaded in Main. Neither the GUI nor the server shutdown thread are necessary for gametest servers.

This PR also adds a test to make sure that reloadable regs support data maps (there were no code changes needed, this test is just to make sure it doesn't break in the future)

1.21.3 version of #1589

@Matyrobbrt Matyrobbrt added bug A bug or error 1.21.3 Targeted at Minecraft 1.21.3 labels Oct 26, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 26, 2024

  • Publish PR to GitHub Packages

Last commit published: bd814f49f664dd7f26a22dba340176e53bb3f6f7.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1632' // https://github.com/neoforged/NeoForge/pull/1632
        url 'https://prmaven.neoforged.net/NeoForge/pr1632'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1632.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1632
cd NeoForge-pr1632
curl -L https://prmaven.neoforged.net/NeoForge/pr1632/net/neoforged/neoforge/21.3.22-beta-pr-1632-1213load-gametest-resources-once/mdk-pr1632.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Matyrobbrt

This comment has been minimized.

@TelepathicGrunt TelepathicGrunt merged commit c8114bf into neoforged:1.21.x Nov 10, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.18-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants