Un-hardcode multiple canFireProjectile
methods
#1681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion from Commoble to remove the hard coding on
AbstractSkeleton.canFireProjectileWeapon
and bind it to a Neoforge functionality tagCurrently only contains
minecraft:bow
within the tag as that is all the vanilla skeleton checks for, added some javadoc to it but maybe specification that it should be items that extendBowItem
is required as Crossbow Logic won't work with skeletonsAlso open to better naming suggestions if that's a thought
Following a quick discussion, now contains 3 tags and more patches which also remove the hardcoding on
Pillager
,AbstractSkeleton
andPiglin
allowing all of these mobs to now use items from their respective tags, which all point towards the common tag for their respective weapons (Bows for Skeletons and Crossbows for Piglins and Pillagers)