Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Daemon JVM discovery to Java 21 #1692

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from
Open

Enable Daemon JVM discovery to Java 21 #1692

wants to merge 1 commit into from
+16 −0

Commits on Nov 18, 2024

  1. Enable Daemon JVM discovery to Java 21 

    Due to the way that Gradle forks (or rather, doesn't fork) the compiler
when the compile task's JVM differs from the Daemon's JVM, if the Gradle
Daemon is not running on Java 21, trying to compile the NeoForge
sources will result in an OutOfMemory error.

To avoid this being a silent problem that is hard to diagnose and figure
out for developers, the Daemon JVM discovery feature is configured to
require and use a Java 21 JVM for the Daemon. (As of Gradle 8.10,
Daemon JVM discovery does not do auto-provisioning in the same way as
the Java toolchains feature does, so the developer has to install a
Java 21 JVM if they do not have one already.)
    @sciwhiz12
    sciwhiz12 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2975f49 View commit details
    Browse the repository at this point in the history