-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesigned Installer box + Rounded UI + Other UI Improvements #15
Conversation
The color of the recommended badge may need to change. Any suggestions. Also, the text color of the badges is made different, for visibility, in dark mode for recommend. I may also set the text color to white in both the light and dark modes. Either way, the pull request is complete. |
Deploying with Cloudflare Pages
|
I will also make the badges more elegant by separating them from the version-name in summary tag. (by not centering the badges too) |
assets/js/neoforge.js
Outdated
mcvers = "1.20.1"; | ||
note = `<b>Note:</b> This file is still called <i>forge</i> because we're trying to maintain compatibility with launchers, assuming they don't hardcode things too much.`; | ||
dropDown_VAL = ` open="open"`; | ||
badges_one = `<font class="badges_stable">RECOMMENDED</font>`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know of a good reason why 1.20.1 would be marked as "recommended". We don't recommend 1.20.1 over any other version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because 1.20.2 is still in beta. OK, I will change recommend with Stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not having a badge for 1.20.1 that remarks it as either recommended or stable. There's nothing particularly important about 1.20.1 which merits a badge.
On the other hand, NF 20.1 merits a BETA
badge because it is in beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I am drafting the pull, to make the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I thought that 20.1 installer is made upwards than 20.2 because it is the stable version.
Instead of hard-coding the 20.2 releases as beta, I'm going to make it dynamic, so that the website do not need to change when stable versions start releasing. |
Fixes Issue: #25 |
Well I didn't see this. Fixed in a different way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that design and I think the badges look really cool, just a few questions. :)
Also fixed the indenting!
Found an easy way to fetch the latest version! Now the website doesn't need to update when new versions come out. |
Also, removed the social widget links animations, since, it feels out of place!
1) Fixed an issue where the notice boxes follow only the system's/browser's color-scheme/theme, instead of the website's theme (when the theme is toggled in the website); now layout 'box' will be used instead of 'notice' to call a tip/warning/note/...; this means that the 'hugo-notice' submodule can be used, without the need of just copying the whole repo into the website just to bring some small modifications. 2) Fixed the Mastodon icon to follow other social icon's color scheme. 3) Some more rounded UI implementations. 4) Updated the 'hugo-notice' submodule to the newest commit. 5) Modified the the warning notice to not look odd, from other notices.
Everything in 0be0287:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe change the mouse to a hand when hovering the text in the dropdowns? Might also be worth making the text non-selectable.
Done! |
[CHECK NEWER COMMENTS FOR UPDATES]
The stable 1.20.1 installer-dropdown is open by default, while the beta version will be closed.
The badges will also guide the user to install the correct version.
Here are some images:
DESKTOP
MOBILE
Also when hovering the dropdowns:
Preview URL: https://pr-15.neoforged-website-previews.pages.dev