Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned Installer box + Rounded UI + Other UI Improvements #15

Merged
merged 22 commits into from
Jan 16, 2024
Merged

Redesigned Installer box + Rounded UI + Other UI Improvements #15

merged 22 commits into from
Jan 16, 2024

Conversation

UltimatChamp
Copy link
Contributor

@UltimatChamp UltimatChamp commented Nov 19, 2023

[CHECK NEWER COMMENTS FOR UPDATES]

The stable 1.20.1 installer-dropdown is open by default, while the beta version will be closed.
The badges will also guide the user to install the correct version.

Here are some images:

DESKTOP

  1. Light

  1. Dark

MOBILE

  1. Light

  1. Dark


Also when hovering the dropdowns:

  1. Light

  1. Dark


Preview URL: https://pr-15.neoforged-website-previews.pages.dev

@UltimatChamp
Copy link
Contributor Author

UltimatChamp commented Nov 19, 2023

The color of the recommended badge may need to change. Any suggestions.

Also, the text color of the badges is made different, for visibility, in dark mode for recommend.

I may also set the text color to white in both the light and dark modes.

Either way, the pull request is complete.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) November 19, 2023 11:32 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Nov 19, 2023

Deploying with Cloudflare Pages

Name Result
Last commit: fc8263827ff3445dd380c2911d54f0612f66c2e0
Status: ✅ Deploy successful!
Preview URL: https://091a0077.neoforged-website-previews.pages.dev
PR Preview URL: https://pr-15.neoforged-website-previews.pages.dev

@UltimatChamp
Copy link
Contributor Author

I will also make the badges more elegant by separating them from the version-name in summary tag. (by not centering the badges too)

mcvers = "1.20.1";
note = `<b>Note:</b> This file is still called <i>forge</i> because we're trying to maintain compatibility with launchers, assuming they don't hardcode things too much.`;
dropDown_VAL = ` open="open"`;
badges_one = `<font class="badges_stable">RECOMMENDED</font>`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of a good reason why 1.20.1 would be marked as "recommended". We don't recommend 1.20.1 over any other version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 1.20.2 is still in beta. OK, I will change recommend with Stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not having a badge for 1.20.1 that remarks it as either recommended or stable. There's nothing particularly important about 1.20.1 which merits a badge.

On the other hand, NF 20.1 merits a BETA badge because it is in beta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I am drafting the pull, to make the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I thought that 20.1 installer is made upwards than 20.2 because it is the stable version.

@UltimatChamp
Copy link
Contributor Author

Instead of hard-coding the 20.2 releases as beta, I'm going to make it dynamic, so that the website do not need to change when stable versions start releasing.

@UltimatChamp UltimatChamp marked this pull request as draft November 20, 2023 09:16
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) November 20, 2023 10:35 Active
@UltimatChamp UltimatChamp marked this pull request as ready for review November 20, 2023 10:44
@UltimatChamp
Copy link
Contributor Author

Here's the final pull:

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) December 10, 2023 15:00 Active
@UltimatChamp
Copy link
Contributor Author

Here are the changes:
Home Page:
DagFZrd
All Versions page:
BDbX5mr

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) December 11, 2023 10:10 Active
@UltimatChamp UltimatChamp changed the title Dropdowns in Installer Page with Cool Badges [FINAL & UPDATED] 20.4-20.3 Links + New All Versions page + Redesigned Installer box Dec 11, 2023
@UltimatChamp
Copy link
Contributor Author

Fixes Issue: #25

@Technici4n
Copy link
Member

Well I didn't see this. Fixed in a different way.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) December 14, 2023 04:47 Active
@UltimatChamp UltimatChamp changed the title [FINAL & UPDATED] 20.4-20.3 Links + New All Versions page + Redesigned Installer box [UPDATED] New All Versions page + Redesigned Installer box Dec 14, 2023
Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that design and I think the badges look really cool, just a few questions. :)

layouts/shortcodes/files.html Show resolved Hide resolved
content/_index.md Outdated Show resolved Hide resolved
layouts/shortcodes/versions.html Outdated Show resolved Hide resolved
assets/js/neoforge.js Outdated Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) December 15, 2023 05:44 Active
@UltimatChamp
Copy link
Contributor Author

Found an easy way to fetch the latest version! Now the website doesn't need to update when new versions come out.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) December 30, 2023 11:29 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) January 4, 2024 07:09 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) January 12, 2024 07:56 Active
UltimatChamp added 2 commits January 12, 2024 13:58
Also, removed the social widget links animations, since, it feels out of place!
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) January 12, 2024 08:39 Active
@UltimatChamp UltimatChamp changed the title [UPDATED] New All Versions page + Redesigned Installer box Redesigned Installer box + Rounded UI + Other UI Improvements Jan 13, 2024
1) Fixed an issue where the notice boxes follow only the system's/browser's color-scheme/theme, instead of the website's theme (when the theme is toggled in the website); now layout 'box' will be used instead of 'notice' to call a tip/warning/note/...; this means that the 'hugo-notice' submodule can be used, without the need of just copying the whole repo into the website just to bring some small modifications.

2) Fixed the Mastodon icon to follow other social icon's color scheme.

3) Some more rounded UI implementations.

4) Updated the 'hugo-notice' submodule to the newest commit.

5) Modified the the warning notice to not look odd, from other notices.
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) January 15, 2024 07:30 Active
@UltimatChamp
Copy link
Contributor Author

UltimatChamp commented Jan 15, 2024

Everything in 0be0287:

  1. Fixed an issue where the notice boxes follow only the system's/browser's color-scheme/theme, instead of the website's theme (when the theme is toggled in the website); now layout 'box' will be used instead of 'notice' to call a tip/warning/note/...; this means that the 'hugo-notice' submodule can be used, without the need of just copying the whole repo into the website just to bring some small modifications.

  2. Fixed the Mastodon icon to follow other social icon's color scheme.

  3. Some more rounded UI implementations.

  4. Updated the 'hugo-notice' submodule to the newest commit.

  5. Modified the the warning notice to not look odd, from other notices.

  6. Old neoforged website-styled code blocks!

Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe change the mouse to a hand when hovering the text in the dropdowns? Might also be worth making the text non-selectable.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) January 16, 2024 10:22 Active
@UltimatChamp
Copy link
Contributor Author

Could you maybe change the mouse to a hand when hovering the text in the dropdowns? Might also be worth making the text non-selectable.

Done!

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-website-previews (Preview) January 16, 2024 10:48 Active
@Technici4n Technici4n merged commit aa834d7 into neoforged:main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants