Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(neon): JsFunction::bind() and Object::prop() #1056

Merged
merged 37 commits into from
Oct 1, 2024
Merged

feat(neon): JsFunction::bind() and Object::prop() #1056

merged 37 commits into from
Oct 1, 2024

Commits on Sep 27, 2024

  1. Implement JsFunction::bind(), which creates a builder for calling a f… 

    …unction using the Try{From,Into}Js traits.
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5195a1b View commit details
    Browse the repository at this point in the history

  2. prettier

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2dce48c View commit details
    Browse the repository at this point in the history

  3. cargo fmt --all

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e23492c View commit details
    Browse the repository at this point in the history

  4. Add PropOptions and Object::prop() for accessing object properties … 

    …expressively
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0f8ff9e View commit details
    Browse the repository at this point in the history

  5. api doc formatting

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a72ea6c View commit details
    Browse the repository at this point in the history

  6. tweak test name for clarity

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1369807 View commit details
    Browse the repository at this point in the history

  7. Optimization: only do the function type check of the callee when call… 

    …ing BindOptions::apply()
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9fa6a0d View commit details
    Browse the repository at this point in the history

  8. rebase: {Bind,Prop}Options take Cx instead of generic C: Context

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5e26ba1 View commit details
    Browse the repository at this point in the history

  9. remove unnecessary sys::fun::call helper, and add test case for calli… 

    …ng non-functions with .bind()
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    670837f View commit details
    Browse the repository at this point in the history

  10. prettier

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1f8e108 View commit details
    Browse the repository at this point in the history

  11. cargo fmt --all

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c2b4d5b View commit details
    Browse the repository at this point in the history

  12. style: move long type parameter list to where-clause

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8b09460 View commit details
    Browse the repository at this point in the history

  13. more style nits (where-clauses)

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f1bc138 View commit details
    Browse the repository at this point in the history

  14. arg_with's closure doesn't need to require a Result, since TryIntoJs … 

    …is already implemented for NeonResult
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6253c56 View commit details
    Browse the repository at this point in the history

  15. remove unnecessary unsafe: use .as_value() instead

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9f13037 View commit details
    Browse the repository at this point in the history

  16. BindOptions::this() takes a TryIntoJs (and is therefore fallible) 

    - tests for both strict and sloppy mode functions to show it works on primitives
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d603630 View commit details
    Browse the repository at this point in the history

  17. store object in PropOptions as a JsObject so it doesn't need a ty… 

    …pe parameter other than for the key
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3305fc2 View commit details
    Browse the repository at this point in the history

  18. avoid the double-type-check of eagerly downcasting to function when c… 

    …alling .bind(), since it's performed when calling .apply()
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b779e37 View commit details
    Browse the repository at this point in the history

  19. style: move the InvalidArg tag check to a match guard 

    Co-authored-by: K.J. Valencik <[email protected]>
    @dherman @kjvalencik
    dherman and kjvalencik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a34531e View commit details
    Browse the repository at this point in the history

  20. argc can be usize now that we're not using the c++ backend

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8f3c58e View commit details
    Browse the repository at this point in the history

  21. BindOptions::args_with() and equivalent BindOptions::args(With(...))

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9050dc4 View commit details
    Browse the repository at this point in the history

  22. more readable logic for impl_arguments! and impl_into_arguments! macros

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    72bc8b8 View commit details
    Browse the repository at this point in the history

  23. move call_local into a method of ValueInternal, so there's less o… 

    …f a weird inconsistency between the callee being something other than a Handle vs the other args
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e37382d View commit details
    Browse the repository at this point in the history

  24. co-locate the impl of TryIntoArguments for With into the same module … 

    …as the other impls
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    12d0217 View commit details
    Browse the repository at this point in the history

  25. safety comment for .prop()

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    41c1376 View commit details
    Browse the repository at this point in the history

  26. PropOptions.set() returns self

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6e44074 View commit details
    Browse the repository at this point in the history

  27. - put back the O: Object type parameter to PropOptions for more pre… 

    …cise typing

- add PropOptions::this() to return the object
- add PropOptions::prop() to enable assignment chaining
    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    fd643a2 View commit details
    Browse the repository at this point in the history

  28. add PropOptions::set_with

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7a4bbe3 View commit details
    Browse the repository at this point in the history

  29. eliminate uses of .get() and .set() in API docs

    @dherman
    dherman committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3d264bc View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. - Object::method() 

    - BindOptions::exec()
- rename BindOptions::apply() to BindOptions::call()
- eliminate call_method_with() from API docs
    @dherman
    dherman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7f1d108 View commit details
    Browse the repository at this point in the history

  2. experiment: can we use #[deprecated(since = "TBD")] for soft deprec… 

    …ation?
    @dherman
    dherman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    84ee9ec View commit details
    Browse the repository at this point in the history

  3. allow fallible args_with

    @dherman
    dherman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2158281 View commit details
    Browse the repository at this point in the history

  4. add BindOptions::construct()

    @dherman
    dherman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b5a76b8 View commit details
    Browse the repository at this point in the history

  5. soft-deprecate JsFunction::{call, construct, call_with, construct_with}

    @dherman
    dherman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    39eaada View commit details
    Browse the repository at this point in the history

  6. Remove .call(), .construct(), .call_with(), and `.construct_wit… 

    …h()` from docs
    @dherman
    dherman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    942fb50 View commit details
    Browse the repository at this point in the history

  7. API docs for JsFunction::bind()

    @dherman
    dherman committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    46918d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. KJ's suggested doc improvements

    @dherman
    dherman committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9bc02b6 View commit details
    Browse the repository at this point in the history