feat(neon): Add neon::types::extract::Boxed for JsBox conversions #1073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsBox<T>
can be extract in an exported function.However, this only works for synchronous functions. If you need boxed data in an async function or task, it requires first cloning it in a sync function, which can be verbose.
However, we can trivially implement
TryFromJs
whereT: Clone
. It must be clone becauseJsBox
only allows immutable references. This allows a much more ergonomic version.Similarly, we can implement
TryIntoJs
forBoxed
by callingcx.boxed(..)
. TheTryIntoJs
implementation does not requireClone
because we already have an owned copy.