feature(create-neon): namespaced libraries #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges. Details: - optionally generate prefix field when generating package.json - bump generated CLI dependency number to 0.1.82 - allow both `quux` and `@foobar/quux` style names in cmdline arg - allow naming scheme to be given explicitly via `--cache npm[:org[/prefix]]`
dherman
changed the title
…r the org, when we're asking for the base name of the package, and when we're asking for the fully qualified package name also, bump the manifest version in create-neon so it recognizes prefixes
dherman
changed the title
… changed) - bugfix: fix double-@ in interactive dialog - tests: add test of interactive dialog when package is namespaced
kjvalencik
approved these changes
Nov 18, 2024
No, it's fully backwards-compatible for users of the CLI. It's only an incompatible change to the programmatic API ( |
Co-authored-by: K.J. Valencik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for namespaced libraries with optionally prefixed binary prebuild packages.
Details:
quuxand@foobar/quuxstyle names in cmdline arg--bins npm[:org[/prefix]]Full case analysis of command-line options:
--app logos-r-us--lib logo-generator@logo-generator""--lib --bins=npm:acme logo-generator@acme"logo-generator-"--lib --bins=npm:acme/libs-logo-generator- logo-generator@acme"libs-logo-generator-"--lib @acme/logo-generator@acme"logo-generator-"--lib --bins=npm:acme-libs @acme/logo-generator@acme-libs"logo-generator-"