neonvm-controller: refactor doReconcile #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
Omrigan
changed the title
Omrigan
force-pushed
the
oleg/controller-refactor
branch
from
2fad2b8
to
8b34ba3
Compare
|
@Omrigan if you're going to rebase-and-merge, could you rename the commits to append the PR number? |
Signed-off-by: Oleg Vasilev <[email protected]>
Signed-off-by: Oleg Vasilev <[email protected]>
corev1.PodUnknown is deprecated, therefore we don't need it. Signed-off-by: Oleg Vasilev <[email protected]>
Omrigan
force-pushed
the
oleg/controller-refactor
branch
from
8b34ba3
to
042df76
Compare
Right, totally forgot! I guess it is 3 strikes to automate it, first take is at https://github.com/neondatabase/autoscaling/pull/1152/files. |
Omrigan
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Oleg Vasilev <[email protected]>
Omrigan
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Oleg Vasilev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best viewed by-commit.
Will be merged with rebase.
Part of the #733.