agent/runner: Fix DesiredVMState incorrect decrease #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharnoff
force-pushed
the
sharnoff/agent-runner-AtomicUpdateState-test
branch
2 times, most recently
from
765736c to
bd2409d
Compare
This should resolve #512 (the second test added was failing before the change to DesiredVMState). The reasoning for the change is given in the comment.
sharnoff
force-pushed
the
sharnoff/agent-runner-fix-DesiredVMState-decrease
branch
from
09d8200 to
cb66f67
Compare
Base automatically changed from
sharnoff/agent-runner-AtomicUpdateState-test
to
main
September 2, 2023 14:19
sharnoff
deleted the
sharnoff/agent-runner-fix-DesiredVMState-decrease
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #512 (the second test added was failing before the change to DesiredVMState).
The reasoning for the change is given in the added comment.