Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_service: add benchmark for batching #9820

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

problame
Copy link
Contributor

@problame problame commented Nov 20, 2024

This PR adds two benchmark to demonstrate the effect of server-side
getpage request batching added in #9321.

For the CPU usage, I found the the prometheus crate's built-in CPU usage accounts the seconds at integer granularity. That's not enough you reduce the target benchmark runtime for local iteration. So, add a new libmetrics metric and report that.

The benchmarks are disabled because on our benchmark nodes, timer resolution isn't high enough.
They work (no statement about quality) on my bare-metal devbox.

They will be refined and enabled once we find a fix. Candidates at time of writing are:

Refs:

This PR adds a benchmark to demonstrate the effect of server-side
getpage request batching added in #9321.

Refs:

- Epic: #9376
- Extracted from #9792
@problame problame added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

5535 tests run: 5318 passed, 0 failed, 217 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.4% (7950 of 25345 functions)
  • lines: 49.3% (63100 of 128036 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3eba1ba at 2024-11-22T12:39:16.085Z :recycle:

@problame problame removed the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Nov 22, 2024
@problame problame enabled auto-merge (squash) November 22, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants