-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
page_service: add benchmark for batching #9820
Open
problame
wants to merge
9
commits into
main
Choose a base branch
from
problame/batching-benchmark
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+347
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
added
the
run-benchmarks
Indicates to the CI that benchmarks should be run for PR marked with this label
label
Nov 20, 2024
This was referenced Nov 20, 2024
5535 tests run: 5318 passed, 0 failed, 217 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
3eba1ba at 2024-11-22T12:39:16.085Z :recycle: |
bayandin
reviewed
Nov 20, 2024
test_runner/performance/pageserver/test_pageserver_getpage_merge.py
Outdated
Show resolved
Hide resolved
VladLazar
approved these changes
Nov 20, 2024
problame
commented
Nov 20, 2024
test_runner/performance/pageserver/test_pageserver_getpage_merge.py
Outdated
Show resolved
Hide resolved
VladLazar
approved these changes
Nov 21, 2024
problame
removed
the
run-benchmarks
Indicates to the CI that benchmarks should be run for PR marked with this label
label
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two benchmark to demonstrate the effect of server-side
getpage request batching added in #9321.
For the CPU usage, I found the the
prometheus
crate's built-in CPU usage accounts the seconds at integer granularity. That's not enough you reduce the target benchmark runtime for local iteration. So, add a newlibmetrics
metric and report that.The benchmarks are disabled because on our benchmark nodes, timer resolution isn't high enough.
They work (no statement about quality) on my bare-metal devbox.
They will be refined and enabled once we find a fix. Candidates at time of writing are:
Refs: