Delete metaData node independent of realtimeExtraction setting #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one set's
Neos.MetaData.Extractor.realtimeExtraction.enabled
to false in Settings.yaml, the signalassetRemoved
is not handled. Thus the nodedata table still contains nodes which have properties where the metadata entry is linked to a resource which does not exist any more, e.g. from properties of such aNeos.MetaData:Image
nodeSo, this patch is about preventing possible inconsistencies in the nodedata table.
This commit, always handles the signal
assetRemoved
usingExtractionManager::onAssetRemoved
which signalsMetaDataCollectionUpdated
viaNeos\MetaData\MetaDataManager
. Thus the asset's metadata node is removed and rebuilding the metadata is also prevented by usingonAssetRemoved
.