Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Repository Test Suite #4455

Merged
merged 39 commits into from
Sep 1, 2023
Merged

Content Repository Test Suite #4455

merged 39 commits into from
Sep 1, 2023

Conversation

nezaniel
Copy link
Member

This extracts testing bootstrap and feature traits to separate packages.
Everything that is usable standalone is now located in Neos.ContentRepository.TestSuite
The Neos.ContentRepositoryRegistry now has a few testing helper classes, mainly for easy 3rd party integration.
The Neos.ContentRepository.BehavioralTests package has been reduced to exactly what we need only for our internal tests.

This way, the Neos.ContentRepository.Core is now completely decoupled from the ContentRepositoryRegistry.

Additionally, only one database adapter is now tested at once.
Also, multiple content repositories can be set up for test cases and will be created or modified from scratch, leading to a much cleaner testing code base.

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the 9.0 branch (https://www.neos.io/features/release-roadmap.html)
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
Copy link
Member

Hmm it seems that the CI Step run ES CR fails:

The following packages have unmet dependencies:
 mariadb-client : Depends: mariadb-client-10.3 (>= 1:10.3.38-0ubuntu0.20.04.1) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
Error: Process completed with exit code 100.

@nezaniel
Copy link
Member Author

Hmm it seems that the CI Step run ES CR fails:

The following packages have unmet dependencies:
 mariadb-client : Depends: mariadb-client-10.3 (>= 1:10.3.38-0ubuntu0.20.04.1) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
Error: Process completed with exit code 100.

Looks like a temporary connection problem to me, we'll need neos/neos-development-distribution#93 though to have behat available

@nezaniel
Copy link
Member Author

...and everything is green again

@@ -37,7 +37,7 @@ class CatchUpTriggerWithSynchronousOption implements ProjectionCatchUpTriggerInt
/**
* INTERNAL
*/
public static function enableSynchonityForSpeedingUpTesting(): void
public static function enableSynchronicityForSpeedingUpTesting(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fixes: #4347

Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in weekly

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by  👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants