-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Repository Test Suite #4455
Conversation
Hmm it seems that the CI Step run ES CR fails:
|
Looks like a temporary connection problem to me, we'll need neos/neos-development-distribution#93 though to have behat available |
...and everything is green again |
Neos.ContentRepository.Core/Classes/Projection/NodeHiddenState/NodeHiddenStateProjection.php
Show resolved
Hide resolved
@@ -37,7 +37,7 @@ class CatchUpTriggerWithSynchronousOption implements ProjectionCatchUpTriggerInt | |||
/** | |||
* INTERNAL | |||
*/ | |||
public static function enableSynchonityForSpeedingUpTesting(): void | |||
public static function enableSynchronicityForSpeedingUpTesting(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks fixes: #4347
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed in weekly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 by 👀
and run them in CI Related: #4455
This extracts testing bootstrap and feature traits to separate packages.
Everything that is usable standalone is now located in Neos.ContentRepository.TestSuite
The Neos.ContentRepositoryRegistry now has a few testing helper classes, mainly for easy 3rd party integration.
The Neos.ContentRepository.BehavioralTests package has been reduced to exactly what we need only for our internal tests.
This way, the Neos.ContentRepository.Core is now completely decoupled from the ContentRepositoryRegistry.
Additionally, only one database adapter is now tested at once.
Also, multiple content repositories can be set up for test cases and will be created or modified from scratch, leading to a much cleaner testing code base.
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions