Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: re-implement nodemigration:migrationcreate command #4459

Merged

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Aug 28, 2023

Review instructions

resolves: #4458

This pull request re-implements the ./flow node:migrationcreate command i introduced with Neos 8.3 and make it work with Neos 9.

Demo

demo-migrationcreate-command

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the [lowest maintained branch](https://www.neos.io/features/release-roadmap.html)
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@crydotsnake crydotsnake self-assigned this Aug 28, 2023
@crydotsnake crydotsnake marked this pull request as draft August 28, 2023 18:08
@crydotsnake crydotsnake changed the title FEATURE: re-implement node:migrationcreate command: FEATURE: re-implement node:migrationcreate command Aug 28, 2023
@crydotsnake crydotsnake changed the title FEATURE: re-implement node:migrationcreate command FEATURE: re-implement nodemigration:migrationcreate command Aug 28, 2023
@crydotsnake crydotsnake force-pushed the feature/4458-node-migrationcreate-command branch from 3b3ddab to fedf86c Compare August 29, 2023 17:05
@crydotsnake crydotsnake marked this pull request as ready for review August 29, 2023 17:21
@dlubitz
Copy link
Contributor

dlubitz commented Aug 29, 2023

Do we really need this command? I simply copies 5 lines of static yaml 🤷‍♂️

Copy link
Member

@ahaeslich ahaeslich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added just a suggestion for your template 😉

@ahaeslich ahaeslich merged commit 2f63e69 into neos:9.0 Sep 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: re-implement node:migrationcreate command for Neos 9
4 participants