-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Overhaul command constructors #4489
Conversation
NOTE: Requires neos/neos-ui#3612 to be merged, too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did look thought the changes. At first more carefully but later a little less ^^ Fine by reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this looks super nice!
…For4489 TASK: Command constructor followup to #4489
Add a named
create
constructor to all commands, add doc comments and remove internal argumentsfrom the default constructor in favor of dedicated
with*()
methodsRelated: #4375
Related: #4487