Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove PropertyCollectionInterface #4513

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

bwaidelich
Copy link
Member

Removes the PropertyCollectionInterface in order to achieve a more reliable behavior and not to give the impression of extension points that are actually not extensible.

Note: This change disables some functional NodeHelperTest because there is currently no easy way to mock the Node read model. We'll address this with #4317

Resolves: #4464

Removes the `PropertyCollectionInterface` in order to achieve
a more reliable behavior and not to give the impression of extension
points that are actually not extensible.

**Note:** This change disables some functional `NodeHelperTest` because
there is currently no easy way to mock the `Node` read model.
We'll address this with #4317

Resolves: #4464
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to address the mocking behavior again, but this change itself makes absolutely sense as discussed.

@bwaidelich bwaidelich merged commit b9e52ba into 9.0 Sep 19, 2023
5 checks passed
@bwaidelich bwaidelich deleted the task/4464-remove-PropertyCollectionInterface branch September 19, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PropertyCollectionInterface
2 participants