TASK: Fix testsuite for simple use cases (in phpunit) #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
task/fix-testsuite-for-simple-use-cases
branch
from
b36eba6
to
298080d
Compare
bwaidelich
reviewed
Nov 10, 2024
Neos.ContentRepository.BehavioralTests/Configuration/Settings.yaml
Outdated
Show resolved
Hide resolved
bwaidelich
reviewed
Nov 10, 2024
There was a problem hiding this comment.
Thank you for your work on this. I can imagine, it wasn't joyful :)
It's not an easy pr to review (especially on a phone screen).
So just a mini comment and the question: shouldn't we replace all the Gherkin... fakes? They always made me wonder why we don't translate the input
mhsdesign
force-pushed
the
task/fix-testsuite-for-simple-use-cases
branch
from
298080d
to
3c20365
Compare
|
Ha thanks for the attempted early review. This was planned as a followup to #5344 but i hadnt rebased so far. The diff is now way more precise. |
mhsdesign
changed the title
# Conflicts: # Neos.ContentRepository.BehavioralTests/Configuration/Settings.yaml # Neos.ContentRepository.BehavioralTests/Configuration/Testing/Behat/Settings.ContentRepositoryRegistry.yaml # Neos.ContentRepository.LegacyNodeMigration/Tests/Behavior/Bootstrap/FeatureContext.php # Neos.ContentRepository.TestSuite/Classes/Behavior/Features/Bootstrap/CRTestSuiteRuntimeVariables.php # Neos.ContentRepository.TestSuite/Classes/Fakes/FakeUserIdProvider.php # Neos.ContentRepository.TestSuite/Classes/Fakes/FakeUserIdProviderFactory.php
…tter document use-case
…eded for testing Instead, we replace the node type manager and rebuild the content repository. See `iChangeTheNodeTypesInContentRepositoryTo` and `FakeNodeTypeManagerFactory`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5344 to remove behat specific logic from test fakes so they can be used in php unit tests easily.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions